HBASE-2764. Force all Chore tasks to have a thread name

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@956766 13f79535-47bb-0310-9956-ffa450edef68

CHANGES.txt

@@ -719,6 +719,7 @@ Release 0.21.0 - Unreleased
    HBASE-2735  Make HBASE-2694 replication-friendly
    HBASE-2683  Make it obvious in the documentation that ZooKeeper needs 
                permanent storage
+   HBASE-2764  Force all Chore tasks to have a thread name
 
   NEW FEATURES
    HBASE-1961  HBase EC2 scripts

src/main/java/org/apache/hadoop/hbase/Chore.java

@@ -46,8 +46,8 @@ public abstract class Chore extends Thread {
    * @param s When this flag is set to true, this thread will cleanup and exit
    * cleanly.
    */
-  public Chore(final int p, final AtomicBoolean s) {
-    super();
+  public Chore(String name, final int p, final AtomicBoolean s) {
+    super(name);
     this.sleeper = new Sleeper(p, s);
     this.stop = s;
   }

src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java

@@ -132,7 +132,8 @@ abstract class BaseScanner extends Chore {
 
   BaseScanner(final HMaster master, final boolean rootRegion,
       final AtomicBoolean stop) {
-    super(master.getConfiguration().
+    super("Scanner for " + (rootRegion ? "-ROOT-":".META.") + " table",
+        master.getConfiguration().
         getInt("hbase.master.meta.thread.rescanfrequency", 60 * 1000), stop);
     this.rootRegion = rootRegion;
     this.master = master;

src/main/java/org/apache/hadoop/hbase/master/OldLogsCleaner.java

@@ -61,7 +61,7 @@ public class OldLogsCleaner extends Chore {
   public OldLogsCleaner(final int p, final AtomicBoolean s,
                         Configuration conf, FileSystem fs,
                         Path oldLogDir) {
-    super(p, s);
+    super("OldLogsCleaner", p, s);
     this.maxDeletedLogs =
         conf.getInt("hbase.master.logcleaner.maxdeletedlogs", 20);
     this.fs = fs;

src/main/java/org/apache/hadoop/hbase/master/ServerManager.java

@@ -104,7 +104,7 @@ public class ServerManager {
    */
   class ServerMonitor extends Chore {
     ServerMonitor(final int period, final AtomicBoolean stop) {
-      super(period, stop);
+      super("ServerMonitor", period, stop);
     }
 
     @Override

src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java

@@ -869,7 +869,7 @@ public class HRegionServer implements HRegionInterface,
 
     MajorCompactionChecker(final HRegionServer h,
         final int sleepTime, final AtomicBoolean stopper) {
-      super(sleepTime, stopper);
+      super("MajorCompactionChecker", sleepTime, stopper);
       this.instance = h;
       LOG.info("Runs every " + sleepTime + "ms");
     }