Apache/hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-6853 IllegalArgument Exception is thrown when an empty region is spliitted(Priya)

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1391759 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
ramkrishna 2012-09-29 06:42:27 +00:00
parent c0b38e6c57
commit 98f566edf2
2 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java
View File

@ -280,6 +280,12 @@ public class SplitTransaction {
throw new IOException(exceptionToThrow); throw new IOException(exceptionToThrow);
} }
if (hstoreFilesToSplit.size() == 0) {
String errorMsg = "No store files to split for the region "+this.parent.getRegionInfo();
LOG.error(errorMsg);
throw new IOException(errorMsg);
}
if (!testing) { if (!testing) {
services.removeFromOnlineRegions(this.parent.getRegionInfo().getEncodedName(), null); services.removeFromOnlineRegions(this.parent.getRegionInfo().getEncodedName(), null);
} }

40
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
View File

@ -541,6 +541,46 @@ public class TestSplitTransactionOnCluster {
testSplitBeforeSettingSplittingInZK(true); testSplitBeforeSettingSplittingInZK(true);
testSplitBeforeSettingSplittingInZK(false); testSplitBeforeSettingSplittingInZK(false);
} }
@Test
public void testShouldThrowIOExceptionIfStoreFileSizeIsEmptyAndSHouldSuccessfullyExecuteRollback()
throws Exception {
final byte[] tableName = Bytes.toBytes("testRollBackShudBeSuccessfulIfStoreFileIsEmpty");
// Create table then get the single region for our new table.
TESTING_UTIL.createTable(tableName, HConstants.CATALOG_FAMILY);
List<HRegion> regions = cluster.getRegions(tableName);
HRegionInfo hri = getAndCheckSingleTableRegion(regions);
int tableRegionIndex = ensureTableRegionNotOnSameServerAsMeta(admin, hri);
int regionServerIndex = cluster.getServerWith(regions.get(0).getRegionName());
HRegionServer regionServer = cluster.getRegionServer(regionServerIndex);
// Turn off balancer so it doesn't cut in and mess up our placements.
this.admin.setBalancerRunning(false, false);
// Turn off the meta scanner so it don't remove parent on us.
cluster.getMaster().setCatalogJanitorEnabled(false);
try {
HRegionServer server = cluster.getRegionServer(tableRegionIndex);
printOutRegions(server, "Initial regions: ");
// Now split.
SplitTransaction st = null;
st = new MockedSplitTransaction(regions.get(0), null);
try {
st.execute(regionServer, regionServer);
} catch (IOException e) {
List<HRegion> daughters = cluster.getRegions(tableName);
assertTrue(daughters.size() == 1);
String node = ZKAssign.getNodeName(regionServer.getZooKeeper(), regions.get(0)
.getRegionInfo().getEncodedName());
assertFalse(ZKUtil.checkExists(regionServer.getZooKeeper(), node) == -1);
assertTrue(st.rollback(regionServer, regionServer));
assertTrue(ZKUtil.checkExists(regionServer.getZooKeeper(), node) == -1);
}
} finally {
admin.setBalancerRunning(true, false);
cluster.getMaster().setCatalogJanitorEnabled(true);
}
}
private void testSplitBeforeSettingSplittingInZK(boolean nodeCreated) throws IOException, private void testSplitBeforeSettingSplittingInZK(boolean nodeCreated) throws IOException,
KeeperException { KeeperException {