Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[jira] [HBASE-5072] Support Max Value for Per-Store Metrics 

Summary:
We were bit in our multi-tenant cluster because one of our Stores
encountered a bug and grew its StoreFile count. We didn't notice this because
the StoreFile count currently reported by the RegionServer is an average of all
Stores in the region. For the per-Store metrics, we should also record the max
so we can notice outliers.

Test Plan: - mvn test -Dtest=TestRegionServerMetrics

Reviewers: JIRA, mbautin, Kannan

Reviewed By: Kannan

CC: stack, nspiegelberg, mbautin, Kannan

Differential Revision: 945

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1221419 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Nicolas Spiegelberg 2011-12-20 18:42:11 +00:00
parent 8fe40ce0e9
commit 9a0eb6f0c2
2 changed files with 29 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java
View File

@ -245,6 +245,7 @@ public class SchemaMetrics {
private final String[] bloomMetricNames = new String[2]; private final String[] bloomMetricNames = new String[2];
private final String[] storeMetricNames = new String[NUM_STORE_METRIC_TYPES]; private final String[] storeMetricNames = new String[NUM_STORE_METRIC_TYPES];
private final String[] storeMetricNamesMax = new String[NUM_STORE_METRIC_TYPES];
private SchemaMetrics(final String tableName, final String cfName) { private SchemaMetrics(final String tableName, final String cfName) {
String metricPrefix = SchemaMetrics.generateSchemaMetricsPrefix( String metricPrefix = SchemaMetrics.generateSchemaMetricsPrefix(
@ -290,8 +291,9 @@ public class SchemaMetrics {
} }
for (StoreMetricType storeMetric : StoreMetricType.values()) { for (StoreMetricType storeMetric : StoreMetricType.values()) {
storeMetricNames[storeMetric.ordinal()] = metricPrefix + String coreName = metricPrefix + storeMetric.toString();
storeMetric.toString(); storeMetricNames[storeMetric.ordinal()] = coreName;
storeMetricNamesMax[storeMetric.ordinal()] = coreName + ".max";
} }
} }
@ -390,13 +392,22 @@ public class SchemaMetrics {
public void accumulateStoreMetric(final Map<String, MutableDouble> tmpMap, public void accumulateStoreMetric(final Map<String, MutableDouble> tmpMap,
StoreMetricType storeMetricType, double val) { StoreMetricType storeMetricType, double val) {
final String key = getStoreMetricName(storeMetricType); final String key = getStoreMetricName(storeMetricType);
if (tmpMap.get(key) != null) { if (tmpMap.get(key) == null) {
tmpMap.get(key).add(val);
} else {
tmpMap.put(key, new MutableDouble(val)); tmpMap.put(key, new MutableDouble(val));
} else {
tmpMap.get(key).add(val);
} }
if (this != ALL_SCHEMA_METRICS) { if (this == ALL_SCHEMA_METRICS) {
// also compute the max value across all Stores on this server
final String maxKey = getStoreMetricNameMax(storeMetricType);
MutableDouble cur = tmpMap.get(maxKey);
if (cur == null) {
tmpMap.put(maxKey, new MutableDouble(val));
} else if (cur.doubleValue() < val) {
cur.setValue(val);
}
} else {
ALL_SCHEMA_METRICS.accumulateStoreMetric(tmpMap, storeMetricType, val); ALL_SCHEMA_METRICS.accumulateStoreMetric(tmpMap, storeMetricType, val);
} }
} }
@ -405,6 +416,10 @@ public class SchemaMetrics {
return storeMetricNames[storeMetricType.ordinal()]; return storeMetricNames[storeMetricType.ordinal()];
} }
public String getStoreMetricNameMax(StoreMetricType storeMetricType) {
return storeMetricNamesMax[storeMetricType.ordinal()];
}
/** /**
* Update a metric that does not get reset on every poll. * Update a metric that does not get reset on every poll.
* @param storeMetricType the store metric to update * @param storeMetricType the store metric to update

10
src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java
View File

@ -116,9 +116,15 @@ public class TestRegionServerMetrics {
for (String cf : FAMILIES) { for (String cf : FAMILIES) {
SchemaMetrics schemaMetrics = SchemaMetrics.getInstance(TABLE_NAME, cf); SchemaMetrics schemaMetrics = SchemaMetrics.getInstance(TABLE_NAME, cf);
assertStoreMetricEquals(NUM_FLUSHES * NUM_REGIONS, assertStoreMetricEquals(NUM_FLUSHES * NUM_REGIONS, schemaMetrics,
schemaMetrics, StoreMetricType.STORE_FILE_COUNT); StoreMetricType.STORE_FILE_COUNT);
} }
// ensure that the max value is also maintained
final String storeMetricName = ALL_METRICS
.getStoreMetricNameMax(StoreMetricType.STORE_FILE_COUNT);
assertEquals("Invalid value for store metric " + storeMetricName,
NUM_FLUSHES, HRegion.getNumericMetric(storeMetricName));
} }