Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-24423 No need to get lock in canSplit because hasReferences will get lock too 

Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
This commit is contained in:
Zheng Wang 2020-05-24 20:10:17 +08:00 committed by Bharath Vissapragada
parent 3235b568da
commit 9f12ef0772
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
View File

@ -2160,17 +2160,12 @@ public class HStore implements Store {
@Override @Override
public boolean canSplit() { public boolean canSplit() {
this.lock.readLock().lock(); // Not split-able if we find a reference store file present in the store.
try { boolean result = !hasReferences();
// Not split-able if we find a reference store file present in the store. if (!result && LOG.isTraceEnabled()) {
boolean result = !hasReferences(); LOG.trace(String.format("Not splittable; has references: %s", this));
if (!result && LOG.isDebugEnabled()) {
LOG.debug("Cannot split region due to reference files being there");
}
return result;
} finally {
this.lock.readLock().unlock();
} }
return result;
} }
@Override @Override