Apache/hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-11413 [findbugs] RV: Negating the result of compareTo()/compare() (Mike Drob)

Browse Source
This commit is contained in:
stack 2014-07-02 10:06:15 -07:00
parent 7a2527da4b
commit 9ff90931dc
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java
View File

@ -294,10 +294,10 @@ public class CatalogJanitor extends Chore {
// Compare start keys. // Compare start keys.
result = Bytes.compareTo(left.getStartKey(), right.getStartKey()); result = Bytes.compareTo(left.getStartKey(), right.getStartKey());
if (result != 0) return result; if (result != 0) return result;
// Compare end keys. // Compare end keys, but flip the operands so parent comes first
result = rowEndKeyComparator.compare(left.getEndKey(), right.getEndKey()); result = rowEndKeyComparator.compare(right.getEndKey(), left.getEndKey());
return -result; // Flip the result so parent comes first. return result;
} }
} }

2
hbase-server/src/main/java/org/apache/hadoop/hbase/migration/NamespaceUpgrade.java
View File

@ -524,7 +524,7 @@ public class NamespaceUpgrade implements Tool {
new Comparator<FileStatus>() { new Comparator<FileStatus>() {
@Override @Override
public int compare(FileStatus left, FileStatus right) { public int compare(FileStatus left, FileStatus right) {
return -left.compareTo(right); return right.compareTo(left);
}}; }};
// logic culled from FSTableDescriptors // logic culled from FSTableDescriptors

2
hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java
View File

@ -378,7 +378,7 @@ public class FSTableDescriptors implements TableDescriptors {
new Comparator<FileStatus>() { new Comparator<FileStatus>() {
@Override @Override
public int compare(FileStatus left, FileStatus right) { public int compare(FileStatus left, FileStatus right) {
return -left.compareTo(right); return right.compareTo(left);
}}; }};
/** /**