Apache/hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-27362 CompactSplit.requestCompactionInternal may bypass compactionsEnabled check (#4768)

Browse Source 
Co-authored-by: comnetwork <comnetwork@163.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
This commit is contained in:
chenglei 2022-09-08 16:39:12 +08:00 committed by GitHub
parent fa3bd7feb9
commit a26cbf1057
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java
View File

@ -315,11 +315,13 @@ public class CompactSplit implements CompactionRequester, PropagatingConfigurati
LOG.info("Re-Initializing compactions because user switched on compactions"); LOG.info("Re-Initializing compactions because user switched on compactions");
reInitializeCompactionsExecutors(); reInitializeCompactionsExecutors();
} }
} else { setCompactionsEnabled(onOrOff);
LOG.info("Interrupting running compactions because user switched off compactions"); return;
interrupt();
} }
setCompactionsEnabled(onOrOff); setCompactionsEnabled(onOrOff);
LOG.info("Interrupting running compactions because user switched off compactions");
interrupt();
} }
private void requestCompactionInternal(HRegion region, String why, int priority, private void requestCompactionInternal(HRegion region, String why, int priority,
@ -336,6 +338,11 @@ public class CompactSplit implements CompactionRequester, PropagatingConfigurati
protected void requestCompactionInternal(HRegion region, HStore store, String why, int priority, protected void requestCompactionInternal(HRegion region, HStore store, String why, int priority,
boolean selectNow, CompactionLifeCycleTracker tracker, boolean selectNow, CompactionLifeCycleTracker tracker,
CompactionCompleteTracker completeTracker, User user) throws IOException { CompactionCompleteTracker completeTracker, User user) throws IOException {
if (!this.isCompactionsEnabled()) {
LOG.info("Ignoring compaction request for " + region + ",because compaction is disabled.");
return;
}
if ( if (
this.server.isStopped() || (region.getTableDescriptor() != null this.server.isStopped() || (region.getTableDescriptor() != null
&& !region.getTableDescriptor().isCompactionEnabled()) && !region.getTableDescriptor().isCompactionEnabled())