diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java index 08536b7cbd5..765ab6ba323 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java @@ -1053,8 +1053,7 @@ public class AssignmentManager implements ServerListener { } } - void checkOnlineRegionsReport(final ServerStateNode serverNode, final Set regionNames) - throws YouAreDeadException { + void checkOnlineRegionsReport(final ServerStateNode serverNode, final Set regionNames) { final ServerName serverName = serverNode.getServerName(); try { for (byte[] regionName: regionNames) { @@ -1097,9 +1096,10 @@ public class AssignmentManager implements ServerListener { } } } catch (IOException e) { - LOG.warn("Killing " + serverName + ": " + e.getMessage()); - killRegionServer(serverNode); - throw (YouAreDeadException)new YouAreDeadException(e.getMessage()).initCause(e); + //See HBASE-21421, we can count on reportRegionStateTransition calls + //We only log a warming here. It could be a network lag. + LOG.warn("Failed to checkOnlineRegionsReport, maybe due to network lag, " + + "if this message continues, be careful of double assign", e); } } diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRogueRSAssignment.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRogueRSAssignment.java index afcf4463426..c88e5837842 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRogueRSAssignment.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRogueRSAssignment.java @@ -45,6 +45,7 @@ import org.junit.AfterClass; import org.junit.Before; import org.junit.BeforeClass; import org.junit.ClassRule; +import org.junit.Ignore; import org.junit.Rule; import org.junit.Test; import org.junit.experimental.categories.Category; @@ -137,7 +138,11 @@ public class TestRogueRSAssignment { admin.setBalancerRunning(true, false); } + /** + * Ignore this test, see HBASE-21421 + */ @Test + @Ignore public void testReportRSWithWrongRegion() throws Exception { final TableName tableName = TableName.valueOf(this.name.getMethodName());