HBASE-22100 False positive for error prone warnings in pre commit job

Signed-off-by: Sean Busbey <busbey@apache.org>
This commit is contained in:
zhangduo 2019-03-27 17:03:02 +08:00
parent 973c0cf293
commit a33b3401cf
1 changed files with 18 additions and 0 deletions

View File

@ -705,6 +705,24 @@ function hbaseanti_patchfile
return 0
}
## @description process the javac output for generating WARNING/ERROR
## @audience private
## @stability evolving
## @param input filename
## @param output filename
# Override the default javac_logfilter so that we can do a sort before outputing the WARNING/ERROR.
# This is because that the output order of the error prone warnings is not stable, so the diff
# method will report unexpected errors if we do not sort it. Notice that a simple sort will cause
# line number being sorted by lexicographical so the output maybe a bit strange to human but it is
# really hard to sort by file name first and then line number and column number in shell...
function hbase_javac_logfilter
{
declare input=$1
declare output=$2
${GREP} -E '\[(ERROR|WARNING)\] /.*\.java:' "${input}" | sort > "${output}"
}
## This is named so that yetus will check us right after running tests.
## Essentially, we check for normal failures and then we look for zombies.
#function hbase_unit_logfilter