Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-24221 addendum to restore public interface on LoadIncrementalHFiles 

Signed-off-by: niuyulin <nyl353@163.com>
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
This commit is contained in:
Nick Dimiduk 2020-06-25 15:03:06 -07:00 committed by Nick Dimiduk
parent 50d1a79255
commit a499eae1aa
1 changed files with 25 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/LoadIncrementalHFiles.java
View File

@ -803,14 +803,35 @@ public class LoadIncrementalHFiles extends Configured implements Tool {
* <p>
* Protected for testing.
* @return empty list if success, list of items to retry on recoverable failure
* @deprecated as of release 2.3.0. Use {@link BulkLoadHFiles} instead.
*/
@Deprecated
@VisibleForTesting
protected List<LoadQueueItem> tryAtomicRegionLoad(final Connection conn,
final TableName tableName, final byte[] first, final Collection<LoadQueueItem> lqis,
boolean copyFile) throws IOException {
List<LoadQueueItem> toRetry = new ArrayList<>();
final TableName tableName, final byte[] first, final Collection<LoadQueueItem> lqis,
boolean copyFile) throws IOException {
ClientServiceCallable<byte[]> serviceCallable =
buildClientServiceCallable(conn, tableName, first, lqis, copyFile);
buildClientServiceCallable(conn, tableName, first, lqis, copyFile);
return tryAtomicRegionLoad(serviceCallable, tableName, first, lqis);
}
/**
* Attempts to do an atomic load of many hfiles into a region. If it fails, it returns a list of
* hfiles that need to be retried. If it is successful it will return an empty list.
* <p>
* NOTE: To maintain row atomicity guarantees, region server callable should succeed atomically
* and fails atomically.
* <p>
* Protected for testing.
* @return empty list if success, list of items to retry on recoverable failure
* @deprecated as of release 2.3.0. Use {@link BulkLoadHFiles} instead.
*/
@Deprecated
@VisibleForTesting
protected List<LoadQueueItem> tryAtomicRegionLoad(ClientServiceCallable<byte[]> serviceCallable,
final TableName tableName, final byte[] first, final Collection<LoadQueueItem> lqis)
throws IOException {
List<LoadQueueItem> toRetry = new ArrayList<>();
try {
Configuration conf = getConf();
byte[] region = RpcRetryingCallerFactory.instantiate(conf, null).<byte[]> newCaller()