Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-20391 close out stale or finished PRs on github. 

* closes #51 - > 1 month since notification
* closes #61 - HBASE-18928 has already closed
* closes #62 - HBASE-18929 has already closed
* closes #67 - HBASE-19386 has already closed
* closes #68 - HBASE-19387 has already closed

Also adds a section to the committer guide in the reference guide about closing PRs.

Signed-off-by: Mike Drob <mdrob@apache.org>
This commit is contained in:
Sean Busbey 2018-04-11 16:30:56 -05:00 committed by Sean Busbey
parent 8f1ac01ad8
commit a5408820b5
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/asciidoc/_chapters/developer.adoc
View File

@ -2177,6 +2177,12 @@ When the amending author is different from the original committer, add notice of
- [DISCUSSION] Best practice when amending commits cherry picked - [DISCUSSION] Best practice when amending commits cherry picked
from master to branch]. from master to branch].
====== Close related GitHub PRs
As a project we work to ensure there's a JIRA associated with each change, but we don't mandate any particular tool be used for reviews. Due to implementation details of the ASF's integration between hosted git repositories and GitHub, the PMC has no ability to directly close PRs on our GitHub repo. In the event that a contributor makes a Pull Request on GitHub, either because the contributor finds that easier than attaching a patch to JIRA or because a reviewer prefers that UI for examining changes, it's important to make note of the PR in the commit that goes to the master branch so that PRs are kept up to date.
To read more about the details of what kinds of commit messages will work with the GitHub "close via keyword in commit" mechanism see link:https://help.github.com/articles/closing-issues-using-keywords/[the GitHub documentation for "Closing issues using keywords"]. In summary, you should include a line with the phrase "closes #XXX", where the XXX is the pull request id. The pull request id is usually given in the GitHub UI in grey at the end of the subject heading.
[[committer.tests]] [[committer.tests]]
====== Committers are responsible for making sure commits do not break the build or tests ====== Committers are responsible for making sure commits do not break the build or tests