Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-11499 AsyncProcess.buildDetailedErrorMessage concatenates strings using + in a loop (Mike Drob)

This commit is contained in:
stack 2014-07-13 21:48:06 -07:00
parent fc57363404
commit a6fd48ba12
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
View File

@ -1407,23 +1407,24 @@ class AsyncProcess {
} }
private String buildDetailedErrorMsg(String string, int index) { private String buildDetailedErrorMsg(String string, int index) {
String error = string + "; called for " + index + StringBuilder error = new StringBuilder(128);
", actionsInProgress " + actionsInProgress.get() + "; replica gets: "; error.append(string).append("; called for ").append(index).append(", actionsInProgress ")
.append(actionsInProgress.get()).append("; replica gets: ");
if (replicaGetIndices != null) { if (replicaGetIndices != null) {
for (int i = 0; i < replicaGetIndices.length; ++i) { for (int i = 0; i < replicaGetIndices.length; ++i) {
error += replicaGetIndices[i] + ", "; error.append(replicaGetIndices[i]).append(", ");
} }
} else { } else {
error += (hasAnyReplicaGets ? "all" : "none"); error.append(hasAnyReplicaGets ? "all" : "none");
} }
error += "; results "; error.append("; results ");
if (results != null) { if (results != null) {
for (int i = 0; i < results.length; ++i) { for (int i = 0; i < results.length; ++i) {
Object o = results[i]; Object o = results[i];
error += ((o == null) ? "null" : o.toString()) + ", "; error.append(((o == null) ? "null" : o.toString())).append(", ");
} }
} }
return error; return error.toString();
} }
@Override @Override