From a9d7c49a59087008986334e8a9e4d0d1f5115acd Mon Sep 17 00:00:00 2001
From: tedyu <yuzhihong@gmail.com>
Date: Wed, 8 Apr 2015 06:15:55 -0700
Subject: [PATCH] HBASE-11864 Enhance HLogPrettyPrinter to print information
 from WAL Header (Chuhan Yang)

---
 .../regionserver/wal/ProtobufLogReader.java   | 15 ++++++++++-
 .../wal/SecureProtobufLogReader.java          |  2 +-
 .../hadoop/hbase/wal/WALPrettyPrinter.java    | 25 ++++++++++++++++++-
 3 files changed, 39 insertions(+), 3 deletions(-)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
index 285f69b6a40..af8b5bbcdb8 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
@@ -91,6 +91,9 @@ public class ProtobufLogReader extends ReaderBase {
   static {
     writerClsNames.add(ProtobufLogWriter.class.getSimpleName());
   }
+  
+  // cell codec classname
+  private String codecClsName = null;
 
   enum WALHdrResult {
     EOF,                   // stream is at EOF when method starts
@@ -153,9 +156,16 @@ public class ProtobufLogReader extends ReaderBase {
   /*
    * Returns names of the accepted writer classes
    */
-  protected List<String> getWriterClsNames() {
+  public List<String> getWriterClsNames() {
     return writerClsNames;
   }
+  
+  /*
+   * Returns the cell codec classname
+   */
+  public String getCodecClsName() {
+      return codecClsName;
+  }
 
   protected WALHdrContext readHeader(Builder builder, FSDataInputStream stream)
       throws IOException {
@@ -207,6 +217,9 @@ public class ProtobufLogReader extends ReaderBase {
       LOG.trace("After reading the trailer: walEditsStopOffset: " + this.walEditsStopOffset
           + ", fileLength: " + this.fileLength + ", " + "trailerPresent: " + trailerPresent);
     }
+    
+    codecClsName = hdrCtxt.getCellCodecClsName();
+    
     return hdrCtxt.getCellCodecClsName();
   }
 
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogReader.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogReader.java
index d175741eac8..0d052d4c068 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogReader.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogReader.java
@@ -51,7 +51,7 @@ public class SecureProtobufLogReader extends ProtobufLogReader {
   }
 
   @Override
-  protected List<String> getWriterClsNames() {
+  public List<String> getWriterClsNames() {
     return writerClsNames;
   }
 
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java
index f0d1e674b2c..e579164d501 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java
@@ -47,6 +47,7 @@ import org.apache.hadoop.hbase.util.Bytes;
 import org.apache.hadoop.hbase.util.FSUtils;
 import org.codehaus.jackson.map.ObjectMapper;
 
+import org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader;
 // imports for things that haven't moved yet.
 import org.apache.hadoop.hbase.regionserver.wal.WALEdit;
 
@@ -242,11 +243,33 @@ public class WALPrettyPrinter {
     if (!fs.isFile(p)) {
       throw new IOException(p + " is not a file");
     }
+
+    WAL.Reader log = WALFactory.createReader(fs, p, conf);
+    
+    if (log instanceof ProtobufLogReader) {
+      List<String> writerClsNames = ((ProtobufLogReader) log).getWriterClsNames();
+      if (writerClsNames != null && writerClsNames.size() > 0) {
+        out.print("Writer Classes: ");
+        for (int i = 0; i < writerClsNames.size(); i++) {
+          out.print(writerClsNames.get(i));
+          if (i != writerClsNames.size() - 1) {
+            out.print(" ");
+          }
+        }
+        out.println();
+      }
+      
+      String cellCodecClsName = ((ProtobufLogReader) log).getCodecClsName();
+      if (cellCodecClsName != null) {
+        out.println("Cell Codec Class: " + cellCodecClsName);
+      }
+    }
+    
     if (outputJSON && !persistentOutput) {
       out.print("[");
       firstTxn = true;
     }
-    WAL.Reader log = WALFactory.createReader(fs, p, conf);
+    
     try {
       WAL.Entry entry;
       while ((entry = log.next()) != null) {