Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-10518 DirectMemoryUtils.getDirectMemoryUsage spams when none is configured 

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1568417 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
ndimiduk 2014-02-14 18:08:51 +00:00
parent d727e505be
commit aa111b80b7
1 changed files with 19 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
hbase-server/src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java
View File

@ -45,25 +45,36 @@ import javax.management.ObjectName;
@InterfaceStability.Evolving @InterfaceStability.Evolving
public class DirectMemoryUtils { public class DirectMemoryUtils {
private static final Log LOG = LogFactory.getLog(DirectMemoryUtils.class); private static final Log LOG = LogFactory.getLog(DirectMemoryUtils.class);
private static final MBeanServer beanServer; private static final String MEMORY_USED = "MemoryUsed";
private static final ObjectName nioDirectPool; private static final MBeanServer BEAN_SERVER;
private static final ObjectName NIO_DIRECT_POOL;
private static final boolean HAS_MEMORY_USED_ATTRIBUTE;
static { static {
// initialize singletons. Only maintain a reference to the MBeanServer if // initialize singletons. Only maintain a reference to the MBeanServer if
// we're able to consume it -- hence convoluted logic. // we're able to consume it -- hence convoluted logic.
ObjectName n = null; ObjectName n = null;
MBeanServer s = null; MBeanServer s = null;
Object a = null;
try { try {
n = new ObjectName("java.nio:type=BufferPool,name=direct"); n = new ObjectName("java.nio:type=BufferPool,name=direct");
} catch (MalformedObjectNameException e) { } catch (MalformedObjectNameException e) {
LOG.warn("Unable to initialize ObjectName for DirectByteBuffer allocations."); LOG.warn("Unable to initialize ObjectName for DirectByteBuffer allocations.");
} finally { } finally {
nioDirectPool = n; NIO_DIRECT_POOL = n;
} }
if (nioDirectPool != null) { if (NIO_DIRECT_POOL != null) {
s = ManagementFactory.getPlatformMBeanServer(); s = ManagementFactory.getPlatformMBeanServer();
} }
beanServer = s; BEAN_SERVER = s;
if (BEAN_SERVER != null) {
try {
a = BEAN_SERVER.getAttribute(NIO_DIRECT_POOL, MEMORY_USED);
} catch (JMException e) {
LOG.debug("Failed to retrieve nio.BufferPool direct MemoryUsed attribute.", e);
}
}
HAS_MEMORY_USED_ATTRIBUTE = a != null;
} }
/** /**
@ -103,12 +114,12 @@ public class DirectMemoryUtils {
* @return the current amount of direct memory used. * @return the current amount of direct memory used.
*/ */
public static long getDirectMemoryUsage() { public static long getDirectMemoryUsage() {
if (beanServer == null || nioDirectPool == null) return 0; if (BEAN_SERVER == null || NIO_DIRECT_POOL == null || !HAS_MEMORY_USED_ATTRIBUTE) return 0;
try { try {
Long value = (Long) beanServer.getAttribute(nioDirectPool, "MemoryUsed"); Long value = (Long) BEAN_SERVER.getAttribute(NIO_DIRECT_POOL, MEMORY_USED);
return value == null ? 0 : value; return value == null ? 0 : value;
} catch (JMException e) { } catch (JMException e) {
LOG.debug("Failed to retrieve nio.BufferPool direct MemoryUsed"); // should print further diagnostic information?
return 0; return 0;
} }
} }