Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-12982 Adding timeouts to TestChoreService

This commit is contained in:
stack 2015-02-06 19:45:25 -08:00
parent 3f4427739d
commit ac175b1bd9
1 changed files with 30 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
hbase-common/src/test/java/org/apache/hadoop/hbase/TestChoreService.java
View File

@ -70,7 +70,7 @@ public class TestChoreService {
public SlowChore(String name, int period) { public SlowChore(String name, int period) {
this(name, new SampleStopper(), period); this(name, new SampleStopper(), period);
} }
public SlowChore(String name, Stoppable stopper, int period) { public SlowChore(String name, Stoppable stopper, int period) {
super(name, stopper, period); super(name, stopper, period);
} }
@ -102,7 +102,7 @@ public class TestChoreService {
public DoNothingChore(String name, int period) { public DoNothingChore(String name, int period) {
super(name, new SampleStopper(), period); super(name, new SampleStopper(), period);
} }
public DoNothingChore(String name, Stoppable stopper, int period) { public DoNothingChore(String name, Stoppable stopper, int period) {
super(name, stopper, period); super(name, stopper, period);
} }
@ -125,7 +125,7 @@ public class TestChoreService {
super(name, stopper, period); super(name, stopper, period);
this.sleepTime = sleepTime; this.sleepTime = sleepTime;
} }
@Override @Override
protected boolean initialChore() { protected boolean initialChore() {
try { try {
@ -153,12 +153,12 @@ public class TestChoreService {
public CountingChore(String name, int period) { public CountingChore(String name, int period) {
this(name, new SampleStopper(), period); this(name, new SampleStopper(), period);
} }
public CountingChore(String name, Stoppable stopper, int period) { public CountingChore(String name, Stoppable stopper, int period) {
this(name, stopper, period, false); this(name, stopper, period, false);
} }
public CountingChore(String name, Stoppable stopper, int period, public CountingChore(String name, Stoppable stopper, int period,
final boolean outputOnTicks) { final boolean outputOnTicks) {
super(name, stopper, period); super(name, stopper, period);
this.countOfChoreCalls = 0; this.countOfChoreCalls = 0;
@ -202,7 +202,7 @@ public class TestChoreService {
public static class FailInitialChore extends ScheduledChore { public static class FailInitialChore extends ScheduledChore {
private int numberOfFailures; private int numberOfFailures;
private int failureThreshold; private int failureThreshold;
/** /**
* @param failThreshold Number of times the Chore fails when trying to execute initialChore * @param failThreshold Number of times the Chore fails when trying to execute initialChore
* before succeeding. * before succeeding.
@ -210,7 +210,7 @@ public class TestChoreService {
public FailInitialChore(String name, int period, int failThreshold) { public FailInitialChore(String name, int period, int failThreshold) {
this(name, new SampleStopper(), period, failThreshold); this(name, new SampleStopper(), period, failThreshold);
} }
public FailInitialChore(String name, Stoppable stopper, int period, int failThreshold) { public FailInitialChore(String name, Stoppable stopper, int period, int failThreshold) {
super(name, stopper, period); super(name, stopper, period);
numberOfFailures = 0; numberOfFailures = 0;
@ -236,7 +236,7 @@ public class TestChoreService {
} }
} }
@Test @Test (timeout=20000)
public void testInitialChorePrecedence() throws InterruptedException { public void testInitialChorePrecedence() throws InterruptedException {
ChoreService service = ChoreService.getInstance(TEST_SERVER_NAME); ChoreService service = ChoreService.getInstance(TEST_SERVER_NAME);
@ -247,7 +247,7 @@ public class TestChoreService {
int loopCount = 0; int loopCount = 0;
boolean brokeOutOfLoop = false; boolean brokeOutOfLoop = false;
while (!chore.isInitialChoreComplete() && chore.isScheduled()) { while (!chore.isInitialChoreComplete() && chore.isScheduled()) {
Thread.sleep(failureThreshold * period); Thread.sleep(failureThreshold * period);
loopCount++; loopCount++;
@ -260,7 +260,7 @@ public class TestChoreService {
assertFalse(brokeOutOfLoop); assertFalse(brokeOutOfLoop);
} }
@Test @Test (timeout=20000)
public void testCancelChore() throws InterruptedException { public void testCancelChore() throws InterruptedException {
final int period = 100; final int period = 100;
ScheduledChore chore1 = new DoNothingChore("chore1", period); ScheduledChore chore1 = new DoNothingChore("chore1", period);
@ -274,7 +274,7 @@ public class TestChoreService {
assertTrue(service.getNumberOfScheduledChores() == 0); assertTrue(service.getNumberOfScheduledChores() == 0);
} }
@Test @Test (timeout=20000)
public void testScheduledChoreConstruction() { public void testScheduledChoreConstruction() {
final String NAME = "chore"; final String NAME = "chore";
final int PERIOD = 100; final int PERIOD = 100;
@ -307,7 +307,7 @@ public class TestChoreService {
invalidDelayChore.getInitialDelay()); invalidDelayChore.getInitialDelay());
} }
@Test @Test (timeout=20000)
public void testChoreServiceConstruction() { public void testChoreServiceConstruction() {
final int corePoolSize = 10; final int corePoolSize = 10;
final int defaultCorePoolSize = ChoreService.MIN_CORE_POOL_SIZE; final int defaultCorePoolSize = ChoreService.MIN_CORE_POOL_SIZE;
@ -322,7 +322,7 @@ public class TestChoreService {
assertEquals(defaultCorePoolSize, invalidInit.getCorePoolSize()); assertEquals(defaultCorePoolSize, invalidInit.getCorePoolSize());
} }
@Test @Test (timeout=20000)
public void testFrequencyOfChores() throws InterruptedException { public void testFrequencyOfChores() throws InterruptedException {
final int period = 100; final int period = 100;
// Small delta that acts as time buffer (allowing chores to complete if running slowly) // Small delta that acts as time buffer (allowing chores to complete if running slowly)
@ -338,7 +338,7 @@ public class TestChoreService {
assertTrue(chore.getCountOfChoreCalls() == 21); assertTrue(chore.getCountOfChoreCalls() == 21);
} }
@Test @Test (timeout=20000)
public void testForceTrigger() throws InterruptedException { public void testForceTrigger() throws InterruptedException {
final int period = 100; final int period = 100;
final int delta = 5; final int delta = 5;
@ -369,13 +369,13 @@ public class TestChoreService {
assertTrue(chore.getCountOfChoreCalls() == 26); assertTrue(chore.getCountOfChoreCalls() == 26);
} }
@Test @Test (timeout=20000)
public void testCorePoolIncrease() throws InterruptedException { public void testCorePoolIncrease() throws InterruptedException {
final int initialCorePoolSize = 3; final int initialCorePoolSize = 3;
ChoreService service = new ChoreService(TEST_SERVER_NAME, initialCorePoolSize); ChoreService service = new ChoreService(TEST_SERVER_NAME, initialCorePoolSize);
assertEquals("Should have a core pool of size: " + initialCorePoolSize, initialCorePoolSize, assertEquals("Should have a core pool of size: " + initialCorePoolSize, initialCorePoolSize,
service.getCorePoolSize()); service.getCorePoolSize());
final int slowChorePeriod = 100; final int slowChorePeriod = 100;
SlowChore slowChore1 = new SlowChore("slowChore1", slowChorePeriod); SlowChore slowChore1 = new SlowChore("slowChore1", slowChorePeriod);
SlowChore slowChore2 = new SlowChore("slowChore2", slowChorePeriod); SlowChore slowChore2 = new SlowChore("slowChore2", slowChorePeriod);
@ -384,9 +384,9 @@ public class TestChoreService {
service.scheduleChore(slowChore1); service.scheduleChore(slowChore1);
service.scheduleChore(slowChore2); service.scheduleChore(slowChore2);
service.scheduleChore(slowChore3); service.scheduleChore(slowChore3);
Thread.sleep(slowChorePeriod * 10); Thread.sleep(slowChorePeriod * 10);
assertEquals("Should not create more pools than scheduled chores", 3, assertEquals("Should not create more pools than scheduled chores", 3,
service.getCorePoolSize()); service.getCorePoolSize());
SlowChore slowChore4 = new SlowChore("slowChore4", slowChorePeriod); SlowChore slowChore4 = new SlowChore("slowChore4", slowChorePeriod);
@ -404,7 +404,7 @@ public class TestChoreService {
service.getCorePoolSize()); service.getCorePoolSize());
} }
@Test @Test (timeout=20000)
public void testCorePoolDecrease() throws InterruptedException { public void testCorePoolDecrease() throws InterruptedException {
final int initialCorePoolSize = 3; final int initialCorePoolSize = 3;
ChoreService service = new ChoreService(TEST_SERVER_NAME, initialCorePoolSize); ChoreService service = new ChoreService(TEST_SERVER_NAME, initialCorePoolSize);
@ -506,7 +506,7 @@ public class TestChoreService {
assertEquals("Should not change", 3, service.getCorePoolSize()); assertEquals("Should not change", 3, service.getCorePoolSize());
} }
@Test @Test (timeout=20000)
public void testNumberOfRunningChores() throws InterruptedException { public void testNumberOfRunningChores() throws InterruptedException {
ChoreService service = new ChoreService(TEST_SERVER_NAME); ChoreService service = new ChoreService(TEST_SERVER_NAME);
@ -543,7 +543,7 @@ public class TestChoreService {
assertEquals("Scheduled chore mismatch", 0, service.getNumberOfScheduledChores()); assertEquals("Scheduled chore mismatch", 0, service.getNumberOfScheduledChores());
} }
@Test @Test (timeout=20000)
public void testNumberOfChoresMissingStartTime() throws InterruptedException { public void testNumberOfChoresMissingStartTime() throws InterruptedException {
ChoreService service = new ChoreService(TEST_SERVER_NAME); ChoreService service = new ChoreService(TEST_SERVER_NAME);
@ -587,7 +587,7 @@ public class TestChoreService {
* been scheduled with the service. For example, if 4 ScheduledChores are scheduled with a * been scheduled with the service. For example, if 4 ScheduledChores are scheduled with a
* ChoreService, the number of threads in the ChoreService's core pool should never exceed 4 * ChoreService, the number of threads in the ChoreService's core pool should never exceed 4
*/ */
@Test @Test (timeout=20000)
public void testMaximumChoreServiceThreads() throws InterruptedException { public void testMaximumChoreServiceThreads() throws InterruptedException {
ChoreService service = new ChoreService(TEST_SERVER_NAME); ChoreService service = new ChoreService(TEST_SERVER_NAME);
@ -610,7 +610,7 @@ public class TestChoreService {
service.scheduleChore(sc3); service.scheduleChore(sc3);
service.scheduleChore(sc4); service.scheduleChore(sc4);
service.scheduleChore(sc5); service.scheduleChore(sc5);
Thread.sleep(sleepTime); Thread.sleep(sleepTime);
assertTrue(service.getCorePoolSize() <= service.getNumberOfScheduledChores()); assertTrue(service.getCorePoolSize() <= service.getNumberOfScheduledChores());
@ -630,7 +630,7 @@ public class TestChoreService {
assertTrue(service.getCorePoolSize() <= service.getNumberOfScheduledChores()); assertTrue(service.getCorePoolSize() <= service.getNumberOfScheduledChores());
} }
@Test @Test (timeout=20000)
public void testScheduledChoreReset() throws InterruptedException { public void testScheduledChoreReset() throws InterruptedException {
final int period = 100; final int period = 100;
ChoreService service = new ChoreService(TEST_SERVER_NAME); ChoreService service = new ChoreService(TEST_SERVER_NAME);
@ -657,7 +657,7 @@ public class TestChoreService {
assertTrue(chore.getTimeOfThisRun() == -1); assertTrue(chore.getTimeOfThisRun() == -1);
} }
@Test @Test (timeout=20000)
public void testChangingChoreServices() throws InterruptedException { public void testChangingChoreServices() throws InterruptedException {
final int period = 100; final int period = 100;
final int sleepTime = 10; final int sleepTime = 10;
@ -691,7 +691,7 @@ public class TestChoreService {
assertTrue(chore.getChoreServicer() == null); assertTrue(chore.getChoreServicer() == null);
} }
@Test @Test (timeout=20000)
public void testTriggerNowFailsWhenNotScheduled() throws InterruptedException { public void testTriggerNowFailsWhenNotScheduled() throws InterruptedException {
final int period = 100; final int period = 100;
// Small sleep time buffer to allow CountingChore to complete // Small sleep time buffer to allow CountingChore to complete
@ -716,7 +716,7 @@ public class TestChoreService {
assertEquals(5, chore.getCountOfChoreCalls()); assertEquals(5, chore.getCountOfChoreCalls());
} }
@Test @Test (timeout=20000)
public void testStopperForScheduledChores() throws InterruptedException { public void testStopperForScheduledChores() throws InterruptedException {
ChoreService service = ChoreService.getInstance(TEST_SERVER_NAME); ChoreService service = ChoreService.getInstance(TEST_SERVER_NAME);
Stoppable stopperForGroup1 = new SampleStopper(); Stoppable stopperForGroup1 = new SampleStopper();
@ -767,7 +767,7 @@ public class TestChoreService {
assertFalse(chore3_group2.isScheduled()); assertFalse(chore3_group2.isScheduled());
} }
@Test @Test (timeout=20000)
public void testShutdownCancelsScheduledChores() throws InterruptedException { public void testShutdownCancelsScheduledChores() throws InterruptedException {
final int period = 100; final int period = 100;
ChoreService service = new ChoreService(TEST_SERVER_NAME); ChoreService service = new ChoreService(TEST_SERVER_NAME);
@ -789,7 +789,7 @@ public class TestChoreService {
assertFalse(successChore3.isScheduled()); assertFalse(successChore3.isScheduled());
} }
@Test @Test (timeout=20000)
public void testShutdownWorksWhileChoresAreExecuting() throws InterruptedException { public void testShutdownWorksWhileChoresAreExecuting() throws InterruptedException {
final int period = 100; final int period = 100;
final int sleep = 5 * period; final int sleep = 5 * period;
@ -814,7 +814,7 @@ public class TestChoreService {
assertTrue(service.isTerminated()); assertTrue(service.isTerminated());
} }
@Test @Test (timeout=20000)
public void testShutdownRejectsNewSchedules() throws InterruptedException { public void testShutdownRejectsNewSchedules() throws InterruptedException {
final int period = 100; final int period = 100;
ChoreService service = new ChoreService(TEST_SERVER_NAME); ChoreService service = new ChoreService(TEST_SERVER_NAME);