From afcdced021adf973e4e4575acf3d7aa59ba56306 Mon Sep 17 00:00:00 2001
From: Michael Stack <stack@apache.org>
Date: Tue, 24 Apr 2012 01:51:14 +0000
Subject: [PATCH] HBASE-5849 On first cluster startup, RS aborts if root znode
 is not available

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1329527 13f79535-47bb-0310-9956-ffa450edef68
---
 .../hbase/regionserver/HRegionServer.java     |   6 -
 .../hadoop/hbase/TestClusterBootOrder.java    | 118 ++++++++++++++++++
 2 files changed, 118 insertions(+), 6 deletions(-)
 create mode 100644 src/test/java/org/apache/hadoop/hbase/TestClusterBootOrder.java

diff --git a/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java b/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
index 025fc53d0e9..36ea2ec5e41 100644
--- a/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
+++ b/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
@@ -535,12 +535,6 @@ public class HRegionServer extends RegionServer
    */
   private void blockAndCheckIfStopped(ZooKeeperNodeTracker tracker)
       throws IOException, InterruptedException {
-    if (false == tracker.checkIfBaseNodeAvailable()) {
-      String errorMsg = "Check the value configured in 'zookeeper.znode.parent'. "
-          + "There could be a mismatch with the one configured in the master.";
-      LOG.error(errorMsg);
-      abort(errorMsg);
-    }
     while (tracker.blockUntilAvailable(this.msgInterval, false) == null) {
       if (this.stopped) {
         throw new IOException("Received the shutdown message while waiting.");
diff --git a/src/test/java/org/apache/hadoop/hbase/TestClusterBootOrder.java b/src/test/java/org/apache/hadoop/hbase/TestClusterBootOrder.java
new file mode 100644
index 00000000000..3bbbdf2826f
--- /dev/null
+++ b/src/test/java/org/apache/hadoop/hbase/TestClusterBootOrder.java
@@ -0,0 +1,118 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase;
+
+import static org.junit.Assert.assertTrue;
+
+import org.apache.hadoop.hbase.util.JVMClusterUtil.MasterThread;
+import org.apache.hadoop.hbase.util.JVMClusterUtil.RegionServerThread;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+/**
+ * Tests the boot order indifference between regionserver and master
+ */
+@Category(MediumTests.class)
+public class TestClusterBootOrder {
+
+  private static final long SLEEP_INTERVAL = 1000;
+  private static final long SLEEP_TIME = 4000;
+
+  private HBaseTestingUtility testUtil;
+  private LocalHBaseCluster cluster;
+  private RegionServerThread rs;
+  private MasterThread master;
+
+  @Before
+  public void setUp() throws Exception {
+    testUtil = new HBaseTestingUtility();
+    testUtil.startMiniZKCluster(1);
+    cluster = new LocalHBaseCluster(testUtil.getConfiguration(), 0, 0);
+  }
+
+  @After
+  public void tearDown() throws Exception {
+    cluster.shutdown();
+    cluster.join();
+    testUtil.shutdownMiniZKCluster();
+  }
+
+  private void startRegionServer() throws Exception {
+    rs = cluster.addRegionServer();
+    rs.start();
+
+    for (int i=0; i * SLEEP_INTERVAL < SLEEP_TIME ;i++) {
+      //we cannot block on wait for rs at this point , since master is not up.
+      Thread.sleep(SLEEP_INTERVAL);
+      assertTrue(rs.isAlive());
+    }
+  }
+
+  private void startMaster() throws Exception {
+    master = cluster.addMaster();
+    master.start();
+
+    for (int i=0; i * SLEEP_INTERVAL < SLEEP_TIME ;i++) {
+      Thread.sleep(SLEEP_INTERVAL);
+      assertTrue(master.isAlive());
+    }
+  }
+
+  private void waitForClusterOnline() {
+    while (true) {
+      if (master.getMaster().isInitialized()) {
+        break;
+      }
+      try {
+        Thread.sleep(100);
+      } catch (InterruptedException ignored) {
+        // Keep waiting
+      }
+    }
+    rs.waitForServerOnline();
+  }
+
+  /**
+   * Tests launching the cluster by first starting regionserver, and then the master
+   * to ensure that it does not matter which is started first.
+   */
+  @Test(timeout = 12000)
+  public void testBootRegionServerFirst() throws Exception {
+    startRegionServer();
+    startMaster();
+    waitForClusterOnline();
+  }
+
+  /**
+   * Tests launching the cluster by first starting master, and then the regionserver
+   * to ensure that it does not matter which is started first.
+   */
+  @Test(timeout = 12000)
+  public void testBootMasterFirst() throws Exception {
+    startMaster();
+    startRegionServer();
+    waitForClusterOnline();
+  }
+
+  @org.junit.Rule
+  public org.apache.hadoop.hbase.ResourceCheckerJUnitRule cu =
+    new org.apache.hadoop.hbase.ResourceCheckerJUnitRule();
+}