Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-10233. VisibilityController is too chatty at DEBUG level 

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1553323 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Andrew Kyle Purtell 2013-12-24 19:58:56 +00:00
parent c78f1e511b
commit b087b697c2
1 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
View File

@ -826,7 +826,9 @@ public class VisibilityController extends BaseRegionObserver implements MasterOb
if (node instanceof LeafExpressionNode) { if (node instanceof LeafExpressionNode) {
identifier = ((LeafExpressionNode) node) identifier = ((LeafExpressionNode) node)
.getIdentifier(); .getIdentifier();
LOG.debug("The identifier is "+identifier); if (LOG.isTraceEnabled()) {
LOG.trace("The identifier is "+identifier);
}
labelOrdinal = this.visibilityManager.getLabelOrdinal(identifier); labelOrdinal = this.visibilityManager.getLabelOrdinal(identifier);
} else { } else {
// This is a NOT node. // This is a NOT node.
@ -977,7 +979,9 @@ public class VisibilityController extends BaseRegionObserver implements MasterOb
// for non-rpc handling, fallback to system user // for non-rpc handling, fallback to system user
user = User.getCurrent(); user = User.getCurrent();
} }
LOG.debug("Current active user name is "+user.getShortName()); if (LOG.isTraceEnabled()) {
LOG.trace("Current active user name is "+user.getShortName());
}
return user; return user;
} }
@ -987,7 +991,9 @@ public class VisibilityController extends BaseRegionObserver implements MasterOb
throw new IOException("Unable to obtain the current user, " throw new IOException("Unable to obtain the current user, "
+ "authorization checks for internal operations will not work correctly!"); + "authorization checks for internal operations will not work correctly!");
} }
LOG.debug("Current user name is "+user.getShortName()); if (LOG.isTraceEnabled()) {
LOG.trace("Current user name is "+user.getShortName());
}
String currentUser = user.getShortName(); String currentUser = user.getShortName();
List<String> superUsers = Lists.asList(currentUser, List<String> superUsers = Lists.asList(currentUser,
this.conf.getStrings(AccessControlLists.SUPERUSER_CONF_KEY, new String[0])); this.conf.getStrings(AccessControlLists.SUPERUSER_CONF_KEY, new String[0]));
@ -1074,7 +1080,9 @@ public class VisibilityController extends BaseRegionObserver implements MasterOb
Put p = new Put(Bytes.toBytes(ordinalCounter)); Put p = new Put(Bytes.toBytes(ordinalCounter));
p.addImmutable( p.addImmutable(
LABELS_TABLE_FAMILY, LABEL_QUALIFIER, label, LABELS_TABLE_TAGS); LABELS_TABLE_FAMILY, LABEL_QUALIFIER, label, LABELS_TABLE_TAGS);
LOG.debug("Adding the label "+labelStr); if (LOG.isDebugEnabled()) {
LOG.debug("Adding the label "+labelStr);
}
puts.add(p); puts.add(p);
ordinalCounter++; ordinalCounter++;
response.addResult(successResult); response.addResult(successResult);
@ -1302,7 +1310,9 @@ public class VisibilityController extends BaseRegionObserver implements MasterOb
throw new IOException("Unable to retrieve calling user"); throw new IOException("Unable to retrieve calling user");
} }
List<String> auths = this.visibilityManager.getAuths(user.getShortName()); List<String> auths = this.visibilityManager.getAuths(user.getShortName());
LOG.debug("The list of auths are "+auths); if (LOG.isTraceEnabled()) {
LOG.trace("The list of auths are "+auths);
}
if (!auths.contains(SYSTEM_LABEL)) { if (!auths.contains(SYSTEM_LABEL)) {
throw new AccessDeniedException("User '" + user.getShortName() throw new AccessDeniedException("User '" + user.getShortName()
+ "' is not authorized to perform this action."); + "' is not authorized to perform this action.");