From b3cfe061e1806bdaf9ecc46def02bfb5769e74bf Mon Sep 17 00:00:00 2001 From: eclark Date: Wed, 28 Aug 2013 22:59:12 +0000 Subject: [PATCH] HBASE-9370 Add logging to Schema change Chaos actions. git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1518412 13f79535-47bb-0310-9956-ffa450edef68 --- .../apache/hadoop/hbase/chaos/actions/AddColumnAction.java | 4 ++++ .../hadoop/hbase/chaos/actions/ChangeEncodingAction.java | 3 +++ .../hadoop/hbase/chaos/actions/ChangeVersionsAction.java | 4 +++- .../hadoop/hbase/chaos/actions/RemoveColumnAction.java | 5 ++++- 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/AddColumnAction.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/AddColumnAction.java index aa8a35c2d5b..744bf1a9170 100644 --- a/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/AddColumnAction.java +++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/AddColumnAction.java @@ -32,9 +32,11 @@ import org.apache.hadoop.hbase.util.Bytes; */ public class AddColumnAction extends Action { private final byte[] tableName; + private final String tableNameString; private HBaseAdmin admin; public AddColumnAction(String tableName) { + tableNameString = tableName; this.tableName = Bytes.toBytes(tableName); } @@ -54,6 +56,8 @@ public class AddColumnAction extends Action { columnDescriptor = new HColumnDescriptor(RandomStringUtils.randomAlphabetic(5)); } + LOG.debug("Performing action: Adding " + columnDescriptor + " to " + tableNameString); + tableDescriptor.addFamily(columnDescriptor); admin.modifyTable(tableName, tableDescriptor); } diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeEncodingAction.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeEncodingAction.java index 9fc8e58939e..44cd3fc1d70 100644 --- a/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeEncodingAction.java +++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeEncodingAction.java @@ -32,11 +32,13 @@ import org.apache.hadoop.hbase.util.Bytes; */ public class ChangeEncodingAction extends Action { private final byte[] tableName; + private final String tableNameString; private HBaseAdmin admin; private Random random; public ChangeEncodingAction(String tableName) { + tableNameString = tableName; this.tableName = Bytes.toBytes(tableName); this.random = new Random(); } @@ -56,6 +58,7 @@ public class ChangeEncodingAction extends Action { return; } + LOG.debug("Performing action: Changing encodings on " + tableNameString); // possible DataBlockEncoding id's int[] possibleIds = {0, 2, 3, 4, 6}; for (HColumnDescriptor descriptor : columnDescriptors) { diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeVersionsAction.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeVersionsAction.java index 499c5010777..1a89df844d1 100644 --- a/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeVersionsAction.java +++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeVersionsAction.java @@ -33,11 +33,13 @@ import org.apache.hadoop.hbase.util.Bytes; */ public class ChangeVersionsAction extends Action { private final byte[] tableName; + private final String tableNameString; private HBaseAdmin admin; private Random random; public ChangeVersionsAction(String tableName) { + tableNameString = tableName; this.tableName = Bytes.toBytes(tableName); this.random = new Random(); } @@ -62,7 +64,7 @@ public class ChangeVersionsAction extends Action { descriptor.setMaxVersions(versions); descriptor.setMinVersions(versions); } - + LOG.debug("Performing action: Changing versions on " + tableNameString); admin.modifyTable(tableName, tableDescriptor); } } diff --git a/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RemoveColumnAction.java b/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RemoveColumnAction.java index 583dc55f698..cd1c3c57edd 100644 --- a/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RemoveColumnAction.java +++ b/hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RemoveColumnAction.java @@ -33,10 +33,12 @@ import org.apache.hadoop.hbase.util.Bytes; public class RemoveColumnAction extends Action { private final byte[] tableName; private final Set protectedColumns; + private final String tableNameString; private HBaseAdmin admin; private Random random; public RemoveColumnAction(String tableName, Set protectedColumns) { + tableNameString = tableName; this.tableName = Bytes.toBytes(tableName); this.protectedColumns = protectedColumns; random = new Random(); @@ -62,7 +64,8 @@ public class RemoveColumnAction extends Action { protectedColumns.contains(columnDescriptors[index].getNameAsString())) { index = random.nextInt(columnDescriptors.length); } - + LOG.debug("Performing action: Removing " + columnDescriptors[index].getName() + " from " + + tableNameString); tableDescriptor.removeFamily(columnDescriptors[index].getName()); admin.modifyTable(tableName, tableDescriptor);