From b436d20d5c05f3738f5d1c91f4c4303410aaaed2 Mon Sep 17 00:00:00 2001 From: Ted Yu Date: Sun, 8 Jun 2014 22:08:19 +0000 Subject: [PATCH] HBASE-10593 FileInputStream in JenkinsHash#main() is never closed --- .../java/org/apache/hadoop/hbase/util/JenkinsHash.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/JenkinsHash.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/JenkinsHash.java index 26fda22dbb8..bd861fd2736 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/util/JenkinsHash.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/util/JenkinsHash.java @@ -253,8 +253,12 @@ public class JenkinsHash extends Hash { byte[] bytes = new byte[512]; int value = 0; JenkinsHash hash = new JenkinsHash(); - for (int length = in.read(bytes); length > 0; length = in.read(bytes)) { - value = hash.hash(bytes, length, value); + try { + for (int length = in.read(bytes); length > 0; length = in.read(bytes)) { + value = hash.hash(bytes, length, value); + } + } finally { + in.close(); } System.out.println(Math.abs(value)); }