Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-20384 [AMv2] Logging format improvements; use encoded name rather than full region name marking transitions

This commit is contained in:
Michael Stack 2018-04-09 20:23:05 -07:00
parent 1b2e80389d
commit ba02a8664b
3 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionPlan.java
View File

@ -189,7 +189,7 @@ public class RegionPlan implements Comparable<RegionPlan> {
@Override @Override
public String toString() { public String toString() {
return "hri=" + this.hri.getRegionNameAsString() + ", source=" + return "hri=" + this.hri.getEncodedName() + ", source=" +
(this.source == null? "": this.source.toString()) + (this.source == null? "": this.source.toString()) +
", destination=" + (this.dest == null? "": this.dest.toString()); ", destination=" + (this.dest == null? "": this.dest.toString());
} }

2
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
View File

@ -864,7 +864,7 @@ public class AssignmentManager implements ServerListener {
final ServerStateNode serverNode = regionStates.getOrCreateServer(serverName); final ServerStateNode serverNode = regionStates.getOrCreateServer(serverName);
if (!reportTransition(regionNode, serverNode, state, seqId)) { if (!reportTransition(regionNode, serverNode, state, seqId)) {
// Don't log if shutting down cluster; during shutdown. // Don't log if shutting down cluster; during shutdown.
LOG.warn("No matchin procedure found for {} to transition to {}", regionNode, state); LOG.warn("No matching procedure found for {} transition to {}", regionNode, state);
} }
} }

7
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateStore.java
View File

@ -118,9 +118,8 @@ public class RegionStateStore {
final long openSeqNum = -1; final long openSeqNum = -1;
// TODO: move under trace, now is visible for debugging // TODO: move under trace, now is visible for debugging
LOG.info(String.format("Load hbase:meta entry region=%s regionState=%s lastHost=%s regionLocation=%s", LOG.info("Load hbase:meta entry region={}, regionState={}, lastHost={}, " +
regionInfo, state, lastHost, regionLocation)); "regionLocation={}", regionInfo.getEncodedName(), state, lastHost, regionLocation);
visitor.visitRegionState(regionInfo, state, regionLocation, lastHost, openSeqNum); visitor.visitRegionState(regionInfo, state, regionLocation, lastHost, openSeqNum);
} }
} }
@ -158,7 +157,7 @@ public class RegionStateStore {
MetaTableAccessor.addRegionInfo(put, regionInfo); MetaTableAccessor.addRegionInfo(put, regionInfo);
final StringBuilder info = final StringBuilder info =
new StringBuilder("pid=").append(pid).append(" updating hbase:meta row=") new StringBuilder("pid=").append(pid).append(" updating hbase:meta row=")
.append(regionInfo.getRegionNameAsString()).append(", regionState=").append(state); .append(regionInfo.getEncodedName()).append(", regionState=").append(state);
if (openSeqNum >= 0) { if (openSeqNum >= 0) {
Preconditions.checkArgument(state == State.OPEN && regionLocation != null, Preconditions.checkArgument(state == State.OPEN && regionLocation != null,
"Open region should be on a server"); "Open region should be on a server");