Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-12540 TestRegionServerMetrics#testMobMetrics test failure (Jingcheng Du and Jiajia Li)

This commit is contained in:
Jonathan M Hsieh 2014-12-10 19:43:59 -08:00
parent 30bc7d5598
commit bd5b3e92de
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java
View File

@ -384,7 +384,7 @@ public class TestRegionServerMetrics {
byte[] cf = Bytes.toBytes("d"); byte[] cf = Bytes.toBytes("d");
byte[] qualifier = Bytes.toBytes("qual"); byte[] qualifier = Bytes.toBytes("qual");
byte[] val = Bytes.toBytes("mobdata"); byte[] val = Bytes.toBytes("mobdata");
int compactionThreshold = conf.getInt("hbase.hstore.compactionThreshold", 3); int numHfiles = conf.getInt("hbase.hstore.compactionThreshold", 3) - 1;
HTableDescriptor htd = new HTableDescriptor(tableName); HTableDescriptor htd = new HTableDescriptor(tableName);
HColumnDescriptor hcd = new HColumnDescriptor(cf); HColumnDescriptor hcd = new HColumnDescriptor(cf);
hcd.setMobEnabled(true); hcd.setMobEnabled(true);
@ -394,14 +394,14 @@ public class TestRegionServerMetrics {
HTable t = TEST_UTIL.createTable(htd, new byte[0][0], conf); HTable t = TEST_UTIL.createTable(htd, new byte[0][0], conf);
HRegion region = rs.getOnlineRegions(tableName).get(0); HRegion region = rs.getOnlineRegions(tableName).get(0);
t.setAutoFlush(true, true); t.setAutoFlush(true, true);
for (int insertCount = 0; insertCount < compactionThreshold; insertCount++) { for (int insertCount = 0; insertCount < numHfiles; insertCount++) {
Put p = new Put(Bytes.toBytes(insertCount)); Put p = new Put(Bytes.toBytes(insertCount));
p.add(cf, qualifier, val); p.add(cf, qualifier, val);
t.put(p); t.put(p);
admin.flush(tableName); admin.flush(tableName);
} }
metricsRegionServer.getRegionServerWrapper().forceRecompute(); metricsRegionServer.getRegionServerWrapper().forceRecompute();
metricsHelper.assertCounter("mobFlushCount", compactionThreshold, serverSource); metricsHelper.assertCounter("mobFlushCount", numHfiles, serverSource);
Scan scan = new Scan(Bytes.toBytes(0), Bytes.toBytes(2)); Scan scan = new Scan(Bytes.toBytes(0), Bytes.toBytes(2));
ResultScanner scanner = t.getScanner(scan); ResultScanner scanner = t.getScanner(scan);
scanner.next(100); scanner.next(100);
@ -412,7 +412,7 @@ public class TestRegionServerMetrics {
region.initialize(); region.initialize();
region.compactStores(true); region.compactStores(true);
metricsRegionServer.getRegionServerWrapper().forceRecompute(); metricsRegionServer.getRegionServerWrapper().forceRecompute();
metricsHelper.assertCounter("mobCompactedFromMobCellsCount", compactionThreshold, metricsHelper.assertCounter("mobCompactedFromMobCellsCount", numHfiles,
serverSource); serverSource);
metricsHelper.assertCounter("mobCompactedIntoMobCellsCount", 0, serverSource); metricsHelper.assertCounter("mobCompactedIntoMobCellsCount", 0, serverSource);
scanner = t.getScanner(scan); scanner = t.getScanner(scan);
@ -420,8 +420,8 @@ public class TestRegionServerMetrics {
metricsRegionServer.getRegionServerWrapper().forceRecompute(); metricsRegionServer.getRegionServerWrapper().forceRecompute();
// metrics are reset by the region initialization // metrics are reset by the region initialization
metricsHelper.assertCounter("mobScanCellsCount", 0, serverSource); metricsHelper.assertCounter("mobScanCellsCount", 0, serverSource);
for (int insertCount = compactionThreshold; for (int insertCount = numHfiles;
insertCount < 2 * compactionThreshold - 1; insertCount++) { insertCount < 2 * numHfiles - 1; insertCount++) {
Put p = new Put(Bytes.toBytes(insertCount)); Put p = new Put(Bytes.toBytes(insertCount));
p.add(cf, qualifier, val); p.add(cf, qualifier, val);
t.put(p); t.put(p);
@ -433,7 +433,7 @@ public class TestRegionServerMetrics {
metricsRegionServer.getRegionServerWrapper().forceRecompute(); metricsRegionServer.getRegionServerWrapper().forceRecompute();
// metrics are reset by the region initialization // metrics are reset by the region initialization
metricsHelper.assertCounter("mobCompactedFromMobCellsCount", 0, serverSource); metricsHelper.assertCounter("mobCompactedFromMobCellsCount", 0, serverSource);
metricsHelper.assertCounter("mobCompactedIntoMobCellsCount", 2 * compactionThreshold - 1, metricsHelper.assertCounter("mobCompactedIntoMobCellsCount", 2 * numHfiles - 1,
serverSource); serverSource);
t.close(); t.close();
admin.close(); admin.close();