diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java index ab07f51b454..fc7aa8eee42 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java @@ -72,7 +72,7 @@ public class ReplicationSink { private static final Log LOG = LogFactory.getLog(ReplicationSink.class); private final Configuration conf; - private Connection sharedHtableCon; + private final Connection sharedHtableCon; private final MetricsSink metrics; private final AtomicLong totalReplicatedEdits = new AtomicLong(); @@ -88,6 +88,7 @@ public class ReplicationSink { this.conf = HBaseConfiguration.create(conf); decorateConf(); this.metrics = new MetricsSink(); + this.sharedHtableCon = ConnectionFactory.createConnection(this.conf); } /** @@ -212,9 +213,7 @@ public class ReplicationSink { */ public void stopReplicationSinkServices() { try { - if (this.sharedHtableCon != null) { - this.sharedHtableCon.close(); - } + this.sharedHtableCon.close(); } catch (IOException e) { LOG.warn("IOException while closing the connection", e); // ignoring as we are closing. } @@ -233,9 +232,6 @@ public class ReplicationSink { } Table table = null; try { - if (this.sharedHtableCon == null) { - this.sharedHtableCon = ConnectionFactory.createConnection(this.conf); - } table = this.sharedHtableCon.getTable(tableName); for (List rows : allRows) { table.batch(rows, null);