From c0ce47d1cb1c6741acf464ec02fe2c28b2625b6a Mon Sep 17 00:00:00 2001 From: Matteo Bertozzi Date: Thu, 5 May 2016 07:24:29 -0700 Subject: [PATCH] HBASE-15755 SnapshotDescriptionUtils and SnapshotTestingUtils do not have any Interface audience marked --- .../hadoop/hbase/snapshot/SnapshotDescriptionUtils.java | 4 +++- .../hadoop/hbase/snapshot/SnapshotTestingUtils.java | 8 +++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java index 79e7312f4c3..b6b608c4923 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java @@ -29,6 +29,7 @@ import org.apache.hadoop.fs.FileSystem; import org.apache.hadoop.fs.Path; import org.apache.hadoop.fs.permission.FsPermission; import org.apache.hadoop.hbase.HConstants; +import org.apache.hadoop.hbase.classification.InterfaceAudience; import org.apache.hadoop.hbase.protobuf.generated.HBaseProtos.SnapshotDescription; import org.apache.hadoop.hbase.security.User; import org.apache.hadoop.hbase.snapshot.SnapshotManifestV2; @@ -71,7 +72,8 @@ import org.apache.hadoop.hbase.util.FSUtils; * {@link #completeSnapshot}, and writing the * {@link SnapshotDescription} to the working snapshot directory. */ -public class SnapshotDescriptionUtils { +@InterfaceAudience.Private +public final class SnapshotDescriptionUtils { /** * Filter that only accepts completed snapshot directories diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/SnapshotTestingUtils.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/SnapshotTestingUtils.java index 6615a8f6f7f..b816200d90f 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/SnapshotTestingUtils.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/SnapshotTestingUtils.java @@ -47,6 +47,7 @@ import org.apache.hadoop.hbase.HTableDescriptor; import org.apache.hadoop.hbase.TableDescriptor; import org.apache.hadoop.hbase.TableName; import org.apache.hadoop.hbase.TableNotEnabledException; +import org.apache.hadoop.hbase.classification.InterfaceAudience; import org.apache.hadoop.hbase.client.Admin; import org.apache.hadoop.hbase.client.SnapshotType; import org.apache.hadoop.hbase.client.BufferedMutator; @@ -80,11 +81,16 @@ import com.google.protobuf.ServiceException; /** * Utilities class for snapshots */ -public class SnapshotTestingUtils { +@InterfaceAudience.Private +public final class SnapshotTestingUtils { private static final Log LOG = LogFactory.getLog(SnapshotTestingUtils.class); private static byte[] KEYS = Bytes.toBytes("0123456789"); + private SnapshotTestingUtils() { + // private constructor for utility class + } + /** * Assert that we don't have any snapshots lists *