Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-23087 Remove the deprecated bulkload method in AsyncClusterConnection (#670) 

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
This commit is contained in:
Duo Zhang 2019-09-29 09:26:40 +08:00 committed by GitHub
parent 836368189a
commit c1a476c492
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
hbase-server/src/main/java/org/apache/hadoop/hbase/client/AsyncClusterConnection.java
View File

@ -75,22 +75,11 @@ public interface AsyncClusterConnection extends AsyncConnection {
CompletableFuture<String> prepareBulkLoad(TableName tableName);
/**
* @deprecated Use bulkLoad(TableName tableName, List<Pair<byte[], String>> familyPaths,
* byte[] row, boolean assignSeqNum, Token<?> userToken, String bulkToken,
* boolean copyFiles, List<String> clusterIds)
*/
@Deprecated
CompletableFuture<Boolean> bulkLoad(TableName tableName, List<Pair<byte[], String>> familyPaths,
byte[] row, boolean assignSeqNum, Token<?> userToken, String bulkToken, boolean copyFiles);
/**
* Securely bulk load a list of HFiles, passing additional list of clusters ids tracking
* clusters where the given bulk load has already been processed
* (important for bulk loading replication).
*
* Defined as default here to avoid breaking callers who rely on the bulkLoad version that
* does not expect additional clusterIds param.
*
* Securely bulk load a list of HFiles, passing additional list of clusters ids tracking clusters
* where the given bulk load has already been processed (important for bulk loading replication).
* <p/>
* Defined as default here to avoid breaking callers who rely on the bulkLoad version that does
* not expect additional clusterIds param.
* @param tableName the target table
* @param familyPaths hdfs path for the the table family dirs containg files to be loaded
* @param row row key
@ -99,13 +88,10 @@ public interface AsyncClusterConnection extends AsyncConnection {
* @param bulkToken bulk load token
* @param copyFiles flag for copying the loaded hfiles
* @param clusterIds list of cluster ids where the given bulk load has already been processed.
* @return
*/
default CompletableFuture<Boolean> bulkLoad(TableName tableName, List<Pair<byte[],
String>> familyPaths, byte[] row, boolean assignSeqNum, Token<?> userToken, String bulkToken,
boolean copyFiles, List<String> clusterIds) {
return null;
}
CompletableFuture<Boolean> bulkLoad(TableName tableName, List<Pair<byte[], String>> familyPaths,
byte[] row, boolean assignSeqNum, Token<?> userToken, String bulkToken, boolean copyFiles,
List<String> clusterIds);
/**
* Clean up after finishing bulk load, no matter success or not.

8
hbase-server/src/main/java/org/apache/hadoop/hbase/client/AsyncClusterConnectionImpl.java
View File

@ -106,14 +106,6 @@ class AsyncClusterConnectionImpl extends AsyncConnectionImpl implements AsyncClu
.call();
}
@Override
public CompletableFuture<Boolean> bulkLoad(TableName tableName,
List<Pair<byte[], String>> familyPaths, byte[] row, boolean assignSeqNum, Token<?> userToken,
String bulkToken, boolean copyFiles) {
return bulkLoad(tableName, familyPaths, row, assignSeqNum,
userToken, bulkToken, copyFiles, null);
}
@Override
public CompletableFuture<Boolean> bulkLoad(TableName tableName,
List<Pair<byte[], String>> familyPaths, byte[] row, boolean assignSeqNum, Token<?> userToken,

4
hbase-server/src/test/java/org/apache/hadoop/hbase/client/DummyAsyncClusterConnection.java
View File

@ -143,8 +143,8 @@ public class DummyAsyncClusterConnection implements AsyncClusterConnection {
@Override
public CompletableFuture<Boolean> bulkLoad(TableName tableName,
List<Pair<byte[], String>> familyPaths, byte[] row, boolean assignSeqNum, Token<?> userToken,
String bulkToken, boolean copyFiles) {
List<Pair<byte[], String>> familyPaths, byte[] row, boolean assignSeqNum, Token<?> userToken,
String bulkToken, boolean copyFiles, List<String> clusterIds) {
return null;
}