Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-24835 Normalizer should log a successful run at INFO level 

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
This commit is contained in:
Nick Dimiduk 2020-08-07 16:56:13 -07:00 committed by Nick Dimiduk
parent 7b099eaa75
commit c1c2e160ec
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
View File

@ -29,6 +29,7 @@ import java.lang.reflect.InvocationTargetException;
import java.net.InetAddress; import java.net.InetAddress;
import java.net.InetSocketAddress; import java.net.InetSocketAddress;
import java.net.UnknownHostException; import java.net.UnknownHostException;
import java.time.Duration;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.Collection; import java.util.Collection;
@ -198,6 +199,7 @@ import org.apache.hadoop.hbase.security.UserProvider;
import org.apache.hadoop.hbase.trace.TraceUtil; import org.apache.hadoop.hbase.trace.TraceUtil;
import org.apache.hadoop.hbase.util.Addressing; import org.apache.hadoop.hbase.util.Addressing;
import org.apache.hadoop.hbase.util.Bytes; import org.apache.hadoop.hbase.util.Bytes;
import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
import org.apache.hadoop.hbase.util.FutureUtils; import org.apache.hadoop.hbase.util.FutureUtils;
import org.apache.hadoop.hbase.util.HBaseFsck; import org.apache.hadoop.hbase.util.HBaseFsck;
import org.apache.hadoop.hbase.util.HFileArchiveUtil; import org.apache.hadoop.hbase.util.HFileArchiveUtil;
@ -1916,6 +1918,7 @@ public class HMaster extends HRegionServer implements MasterServices {
* or normalization is globally disabled). * or normalization is globally disabled).
*/ */
public boolean normalizeRegions() throws IOException { public boolean normalizeRegions() throws IOException {
final long startTime = EnvironmentEdgeManager.currentTime();
if (regionNormalizerTracker == null || !regionNormalizerTracker.isNormalizerOn()) { if (regionNormalizerTracker == null || !regionNormalizerTracker.isNormalizerOn()) {
LOG.debug("Region normalization is disabled, don't run region normalizer."); LOG.debug("Region normalization is disabled, don't run region normalizer.");
return false; return false;
@ -1933,6 +1936,7 @@ public class HMaster extends HRegionServer implements MasterServices {
return true; return true;
} }
int affectedTables = 0;
try { try {
final List<TableName> allEnabledTables = final List<TableName> allEnabledTables =
new ArrayList<>(tableStateManager.getTablesInStates(TableState.State.ENABLED)); new ArrayList<>(tableStateManager.getTablesInStates(TableState.State.ENABLED));
@ -1961,6 +1965,7 @@ public class HMaster extends HRegionServer implements MasterServices {
continue; continue;
} }
affectedTables++;
// as of this writing, `plan.submit()` is non-blocking and uses Async Admin APIs to // as of this writing, `plan.submit()` is non-blocking and uses Async Admin APIs to
// submit task , so there's no artificial rate- // submit task , so there's no artificial rate-
// limiting of merge/split requests due to this serial loop. // limiting of merge/split requests due to this serial loop.
@ -1974,11 +1979,10 @@ public class HMaster extends HRegionServer implements MasterServices {
} }
} }
} }
int totalPlansSubmitted = submittedPlanProcIds.size(); final long endTime = EnvironmentEdgeManager.currentTime();
if (totalPlansSubmitted > 0 && LOG.isDebugEnabled()) { LOG.info("Normalizer ran successfully in {}. Submitted {} plans, affecting {} tables.",
LOG.debug("Normalizer plans submitted. Total plans count: {} , procID list: {}", Duration.ofMillis(endTime - startTime), submittedPlanProcIds.size(), affectedTables);
totalPlansSubmitted, submittedPlanProcIds); LOG.debug("Normalizer submitted procID list: {}", submittedPlanProcIds);
}
} finally { } finally {
normalizationInProgressLock.unlock(); normalizationInProgressLock.unlock();
} }