From c1cd6d5a89966f3cfec378146f8088f80d6d36ac Mon Sep 17 00:00:00 2001 From: Ted Yu Date: Mon, 27 Aug 2018 20:31:08 -0700 Subject: [PATCH] HBASE-21088 HStoreFile should be closed in HStore#hasReferences --- .../org/apache/hadoop/hbase/regionserver/HStore.java | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java index 7566a7037da..80f1f21c836 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java @@ -1670,6 +1670,17 @@ public class HStore implements Store, HeapSize, StoreConfigInformation, Propagat LOG.error("Error trying to determine if store has references, assuming references exists", ioe); return true; + } finally { + if (reloadedStoreFiles != null) { + for (HStoreFile storeFile : reloadedStoreFiles) { + try { + storeFile.closeStoreFile(false); + } catch (IOException ioe) { + LOG.warn("Encountered exception closing " + storeFile + ": " + ioe.getMessage()); + // continue with closing the remaining store files + } + } + } } }