Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-27253 make slowlog configurations dynamic (#4926) 

Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
This commit is contained in:
Ray Mattingly 2022-12-15 17:52:49 -05:00 committed by GitHub
parent 5fc4328d2c
commit c30f53c1e9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 35 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
View File

@ -92,7 +92,7 @@ public abstract class RpcServer implements RpcServerInterface, ConfigurationObse
private static final String MULTI_SERVICE_CALLS = "multi.service_calls"; private static final String MULTI_SERVICE_CALLS = "multi.service_calls";
private final boolean authorize; private final boolean authorize;
private final boolean isOnlineLogProviderEnabled; private volatile boolean isOnlineLogProviderEnabled;
protected boolean isSecurityEnabled; protected boolean isSecurityEnabled;
public static final byte CURRENT_VERSION = 0; public static final byte CURRENT_VERSION = 0;
@ -196,8 +196,8 @@ public abstract class RpcServer implements RpcServerInterface, ConfigurationObse
protected static final Gson GSON = GsonUtil.createGsonWithDisableHtmlEscaping().create(); protected static final Gson GSON = GsonUtil.createGsonWithDisableHtmlEscaping().create();
protected final int maxRequestSize; protected final int maxRequestSize;
protected final int warnResponseTime; protected volatile int warnResponseTime;
protected final int warnResponseSize; protected volatile int warnResponseSize;
protected final int minClientRequestTimeout; protected final int minClientRequestTimeout;
@ -275,8 +275,8 @@ public abstract class RpcServer implements RpcServerInterface, ConfigurationObse
this.maxQueueSizeInBytes = this.maxQueueSizeInBytes =
this.conf.getLong("hbase.ipc.server.max.callqueue.size", DEFAULT_MAX_CALLQUEUE_SIZE); this.conf.getLong("hbase.ipc.server.max.callqueue.size", DEFAULT_MAX_CALLQUEUE_SIZE);
this.warnResponseTime = conf.getInt(WARN_RESPONSE_TIME, DEFAULT_WARN_RESPONSE_TIME); this.warnResponseTime = getWarnResponseTime(conf);
this.warnResponseSize = conf.getInt(WARN_RESPONSE_SIZE, DEFAULT_WARN_RESPONSE_SIZE); this.warnResponseSize = getWarnResponseSize(conf);
this.minClientRequestTimeout = this.minClientRequestTimeout =
conf.getInt(MIN_CLIENT_REQUEST_TIMEOUT, DEFAULT_MIN_CLIENT_REQUEST_TIMEOUT); conf.getInt(MIN_CLIENT_REQUEST_TIMEOUT, DEFAULT_MIN_CLIENT_REQUEST_TIMEOUT);
this.maxRequestSize = conf.getInt(MAX_REQUEST_SIZE, DEFAULT_MAX_REQUEST_SIZE); this.maxRequestSize = conf.getInt(MAX_REQUEST_SIZE, DEFAULT_MAX_REQUEST_SIZE);
@ -297,8 +297,7 @@ public abstract class RpcServer implements RpcServerInterface, ConfigurationObse
saslProps = Collections.emptyMap(); saslProps = Collections.emptyMap();
} }
this.isOnlineLogProviderEnabled = conf.getBoolean(HConstants.SLOW_LOG_BUFFER_ENABLED_KEY, this.isOnlineLogProviderEnabled = getIsOnlineLogProviderEnabled(conf);
HConstants.DEFAULT_ONLINE_LOG_PROVIDER_ENABLED);
this.scheduler = scheduler; this.scheduler = scheduler;
} }
@ -311,6 +310,35 @@ public abstract class RpcServer implements RpcServerInterface, ConfigurationObse
if (authorize) { if (authorize) {
refreshAuthManager(newConf, new HBasePolicyProvider()); refreshAuthManager(newConf, new HBasePolicyProvider());
} }
refreshSlowLogConfiguration(newConf);
}
private void refreshSlowLogConfiguration(Configuration newConf) {
boolean newIsOnlineLogProviderEnabled = getIsOnlineLogProviderEnabled(newConf);
if (isOnlineLogProviderEnabled != newIsOnlineLogProviderEnabled) {
isOnlineLogProviderEnabled = newIsOnlineLogProviderEnabled;
}
int newWarnResponseTime = getWarnResponseTime(newConf);
if (warnResponseTime != newWarnResponseTime) {
warnResponseTime = newWarnResponseTime;
}
int newWarnResponseSize = getWarnResponseSize(newConf);
if (warnResponseSize != newWarnResponseSize) {
warnResponseSize = newWarnResponseSize;
}
}
private static boolean getIsOnlineLogProviderEnabled(Configuration conf) {
return conf.getBoolean(HConstants.SLOW_LOG_BUFFER_ENABLED_KEY,
HConstants.DEFAULT_ONLINE_LOG_PROVIDER_ENABLED);
}
private static int getWarnResponseTime(Configuration conf) {
return conf.getInt(WARN_RESPONSE_TIME, DEFAULT_WARN_RESPONSE_TIME);
}
private static int getWarnResponseSize(Configuration conf) {
return conf.getInt(WARN_RESPONSE_SIZE, DEFAULT_WARN_RESPONSE_SIZE);
} }
protected void initReconfigurable(Configuration confToLoad) { protected void initReconfigurable(Configuration confToLoad) {