From c3ce02d5928e1a8ed4b92d37ae837b20104d468c Mon Sep 17 00:00:00 2001 From: Michael Stack Date: Fri, 16 Dec 2016 10:10:14 -0800 Subject: [PATCH] HBASE-17326 Fix findbugs warning in BufferedMutatorParams Fix above and the other hbase-server findbugs complaint about null-check --- .../org/apache/hadoop/hbase/client/BufferedMutatorParams.java | 2 +- .../java/org/apache/hadoop/hbase/mapreduce/CellCounter.java | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorParams.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorParams.java index a325eb6b471..bdb33c3e198 100644 --- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorParams.java +++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorParams.java @@ -30,7 +30,7 @@ import org.apache.hadoop.hbase.classification.InterfaceStability; */ @InterfaceAudience.Public @InterfaceStability.Evolving -public class BufferedMutatorParams { +public class BufferedMutatorParams implements Cloneable { static final int UNSET = -1; diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java index e2af7628be9..745a750de86 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java @@ -131,6 +131,8 @@ public class CellCounter extends Configured implements Tool { */ @Override + @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="NP_NULL_ON_SOME_PATH", + justification="Findbugs is blind to the Precondition null check") public void map(ImmutableBytesWritable row, Result values, Context context) throws IOException {