Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-12431 Use of getColumnLatestCell(byte[], int, int, byte[], int, int) is Not Thread Safe (Jingcheng Du)

This commit is contained in:
stack 2014-12-03 22:34:27 -08:00
parent 8182e88297
commit c45772e76a
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
View File

@ -84,8 +84,7 @@ public class Result implements CellScannable, CellScanner {
// Ditto for familyMap. It can be composed on fly from passed in kvs. // Ditto for familyMap. It can be composed on fly from passed in kvs.
private transient NavigableMap<byte[], NavigableMap<byte[], NavigableMap<Long, byte[]>>> familyMap = null; private transient NavigableMap<byte[], NavigableMap<byte[], NavigableMap<Long, byte[]>>> familyMap = null;
// never use directly private static ThreadLocal<byte[]> localBuffer = new ThreadLocal<byte[]>();
private static byte [] buffer = null;
private static final int PAD_WIDTH = 128; private static final int PAD_WIDTH = 128;
public static final Result EMPTY_RESULT = new Result(); public static final Result EMPTY_RESULT = new Result();
@ -275,9 +274,11 @@ public class Result implements CellScannable, CellScanner {
double keyValueSize = (double) double keyValueSize = (double)
KeyValue.getKeyValueDataStructureSize(kvs[0].getRowLength(), flength, qlength, 0); KeyValue.getKeyValueDataStructureSize(kvs[0].getRowLength(), flength, qlength, 0);
byte[] buffer = localBuffer.get();
if (buffer == null || keyValueSize > buffer.length) { if (buffer == null || keyValueSize > buffer.length) {
// pad to the smallest multiple of the pad width // pad to the smallest multiple of the pad width
buffer = new byte[(int) Math.ceil(keyValueSize / PAD_WIDTH) * PAD_WIDTH]; buffer = new byte[(int) Math.ceil(keyValueSize / PAD_WIDTH) * PAD_WIDTH];
localBuffer.set(buffer);
} }
Cell searchTerm = KeyValueUtil.createFirstOnRow(buffer, 0, Cell searchTerm = KeyValueUtil.createFirstOnRow(buffer, 0,