Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-17171 Proactively catch the case when no time remains for random reads 

The framework sets a configuration property to control how long reads
should be executed. When writes take too long, no time remains for reads
and the user sees an error about a property they must set. We should
prevent this case and log an appropriate message.

Also fixes a rogue character in the class-level javadoc.

Signed-off-by: Michael Stack <stack@apache.org>
This commit is contained in:
Josh Elser 2016-11-23 13:25:53 -05:00 committed by Michael Stack
parent a6f3057dbf
commit c50a79a9ee
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestTimeBoundedRequestsWithRegionReplicas.java
View File

@ -73,7 +73,7 @@ import com.google.common.collect.Lists;
* These parameters (and some other parameters from LoadTestTool) can be used to * These parameters (and some other parameters from LoadTestTool) can be used to
* control behavior, given values are default: * control behavior, given values are default:
* <pre> * <pre>
* -Dhbase.DIntegrationTestTimeBoundedRequestsWithRegionReplicas.runtime=600000 * -Dhbase.IntegrationTestTimeBoundedRequestsWithRegionReplicas.runtime=600000
* -DIntegrationTestTimeBoundedRequestsWithRegionReplicas.num_regions_per_server=5 * -DIntegrationTestTimeBoundedRequestsWithRegionReplicas.num_regions_per_server=5
* -DIntegrationTestTimeBoundedRequestsWithRegionReplicas.get_timeout_ms=5000 * -DIntegrationTestTimeBoundedRequestsWithRegionReplicas.get_timeout_ms=5000
* -DIntegrationTestTimeBoundedRequestsWithRegionReplicas.num_keys_per_server=2500 * -DIntegrationTestTimeBoundedRequestsWithRegionReplicas.num_keys_per_server=2500
@ -200,6 +200,16 @@ public class IntegrationTestTimeBoundedRequestsWithRegionReplicas extends Integr
// set the intended run time for the reader. The reader will do read requests // set the intended run time for the reader. The reader will do read requests
// to random keys for this amount of time. // to random keys for this amount of time.
long remainingTime = runtime - (System.currentTimeMillis() - start); long remainingTime = runtime - (System.currentTimeMillis() - start);
if (remainingTime <= 0) {
LOG.error("The amount of time left for the test to perform random reads is "
+ "non-positive. Increase the test execution time via "
+ String.format(RUN_TIME_KEY,
IntegrationTestTimeBoundedRequestsWithRegionReplicas.class.getSimpleName())
+ " or reduce the amount of data written per server via "
+ IntegrationTestTimeBoundedRequestsWithRegionReplicas.class.getSimpleName()
+ "." + IntegrationTestIngest.NUM_KEYS_PER_SERVER_KEY);
throw new IllegalArgumentException("No time remains to execute random reads");
}
LOG.info("Reading random keys from the table for " + remainingTime/60000 + " min"); LOG.info("Reading random keys from the table for " + remainingTime/60000 + " min");
this.conf.setLong( this.conf.setLong(
String.format(RUN_TIME_KEY, TimeBoundedMultiThreadedReader.class.getSimpleName()) String.format(RUN_TIME_KEY, TimeBoundedMultiThreadedReader.class.getSimpleName())