Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-23077 move entirely to spotbugs (#1265) 

Signed-off-by: Sean Busbey <busbey@apache.org>
This commit is contained in:
Duo Zhang 2020-03-12 10:18:09 +08:00 committed by GitHub
parent cf121227aa
commit c5aa2bc121
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
25 changed files with 122 additions and 115 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
dev-support/docker/Dockerfile
View File

@ -38,14 +38,13 @@ ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en LC_ALL=en_US.UTF-8
# download sundry dependencies # download sundry dependencies
# #
FROM BASE_IMAGE AS FINDBUGS_DOWNLOAD_IMAGE FROM BASE_IMAGE AS SPOTBUGS_DOWNLOAD_IMAGE
# TODO: replace with Spotbugs HBASE-23077, HBASE-22383 ENV SPOTBUGS_VERSION '3.1.12'
ENV FINDBUGS_VERSION '3.0.1' ENV SPOTBUGS_URL "https://repo.maven.apache.org/maven2/com/github/spotbugs/spotbugs/${SPOTBUGS_VERSION}/spotbugs-${SPOTBUGS_VERSION}.tgz"
ENV FINDBUGS_URL "https://downloads.sourceforge.net/project/findbugs/findbugs/${FINDBUGS_VERSION}/findbugs-${FINDBUGS_VERSION}.tar.gz" ENV SPOTBUGS_SHA256 '9c475d6c7096ed7af783e04dc2db40462145291de75a80029391600b6eb2d401'
ENV FINDBUGS_SHA256 'e80e0da0c213a27504ef3188ef25f107651700ffc66433eac6a7454bbe336419'
SHELL ["/bin/bash", "-o", "pipefail", "-c"] SHELL ["/bin/bash", "-o", "pipefail", "-c"]
RUN curl --location --fail --silent --show-error --output /tmp/findbugs.tar.gz "${FINDBUGS_URL}" && \ RUN curl --location --fail --silent --show-error --output /tmp/spotbugs.tgz "${SPOTBUGS_URL}" && \
echo "${FINDBUGS_SHA256} */tmp/findbugs.tar.gz" | sha256sum -c - echo "${SPOTBUGS_SHA256} */tmp/spotbugs.tgz" | sha256sum -c -
FROM BASE_IMAGE AS HADOLINT_DOWNLOAD_IMAGE FROM BASE_IMAGE AS HADOLINT_DOWNLOAD_IMAGE
ENV HADOLINT_VERSION '1.17.5' ENV HADOLINT_VERSION '1.17.5'
@ -133,10 +132,10 @@ RUN gem install --no-document \
ruby-lint:2.3.1 ruby-lint:2.3.1
# hadolint ignore=DL3010 # hadolint ignore=DL3010
COPY --from=FINDBUGS_DOWNLOAD_IMAGE /tmp/findbugs.tar.gz /tmp/findbugs.tar.gz COPY --from=SPOTBUGS_DOWNLOAD_IMAGE /tmp/spotbugs.tgz /tmp/spotbugs.tgz
RUN tar xzf /tmp/findbugs.tar.gz -C /opt && \ RUN tar xzf /tmp/spotbugs.tgz -C /opt && \
ln -s "/opt/$(dirname "$(tar -tf /tmp/findbugs.tar.gz | head -n1)")" /opt/findbugs && \ ln -s "/opt/$(tar -tf /tmp/spotbugs.tgz | head -n1 | cut -d/ -f1)" /opt/spotbugs && \
rm /tmp/findbugs.tar.gz rm /tmp/spotbugs.tgz
COPY --from=HADOLINT_DOWNLOAD_IMAGE /tmp/hadolint /tmp/hadolint COPY --from=HADOLINT_DOWNLOAD_IMAGE /tmp/hadolint /tmp/hadolint
RUN mv /tmp/hadolint /usr/local/bin && \ RUN mv /tmp/hadolint /usr/local/bin && \
@ -184,9 +183,9 @@ RUN mkdir -p /usr/lib/jvm && \
# these values to be specified here; the various --foo-path flags do not # these values to be specified here; the various --foo-path flags do not
# propigate as expected, while these are honored. # propigate as expected, while these are honored.
# TODO (nd): is this really true? investigate and file a ticket. # TODO (nd): is this really true? investigate and file a ticket.
ENV FINDBUGS_HOME '/opt/findbugs' ENV SPOTBUGS_HOME '/opt/spotbugs'
ENV MAVEN_HOME '/opt/maven' ENV MAVEN_HOME '/opt/maven'
ENV MAVEN_OPTS '-Xms6G -Xmx6G' ENV MAVEN_OPTS '-Xms4G -Xmx4G'
CMD ["/bin/bash"] CMD ["/bin/bash"]

26
dev-support/hbase-personality.sh
View File

@ -184,18 +184,30 @@ function personality_modules
done done
fi fi
if [[ ${testtype} == findbugs ]]; then if [[ ${testtype} == spotbugs ]]; then
# Run findbugs on each module individually to diff pre-patch and post-patch results and # Run spotbugs on each module individually to diff pre-patch and post-patch results and
# report new warnings for changed modules only. # report new warnings for changed modules only.
# For some reason, findbugs on root is not working, but running on individual modules is # For some reason, spotbugs on root is not working, but running on individual modules is
# working. For time being, let it run on original list of CHANGED_MODULES. HBASE-19491 # working. For time being, let it run on original list of CHANGED_MODULES. HBASE-19491
for module in "${CHANGED_MODULES[@]}"; do for module in "${CHANGED_MODULES[@]}"; do
# skip findbugs on hbase-shell and hbase-it. hbase-it has nothing # skip spotbugs on hbase-shell and hbase-it. hbase-it has nothing
# in src/main/java where findbugs goes to look # in src/main/java where spotbugs goes to look
# skip hbase-shaded* as there is no java code in them
# skip all modules with no java code or at least, non test java code
if [[ ${module} == hbase-shell ]]; then if [[ ${module} == hbase-shell ]]; then
continue continue
elif [[ ${module} == hbase-it ]]; then elif [[ ${module} == hbase-it ]]; then
continue continue
elif [[ ${module} == hbase-shaded* ]]; then
continue
elif [[ ${module} == hbase-build-configuration ]]; then
continue
elif [[ ${module} == hbase-checkstyle ]]; then
continue
elif [[ ${module} == hbase-resource-bundle ]]; then
continue
elif [[ ${module} == hbase-testing-util ]]; then
continue
else else
# shellcheck disable=SC2086 # shellcheck disable=SC2086
personality_enqueue_module ${module} ${extra} personality_enqueue_module ${module} ${extra}
@ -375,7 +387,7 @@ function refguide_rebuild
$(maven_executor) clean site --batch-mode \ $(maven_executor) clean site --batch-mode \
-pl . \ -pl . \
-Dtest=NoUnitTests -DHBasePatchProcess -Prelease \ -Dtest=NoUnitTests -DHBasePatchProcess -Prelease \
-Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dspotbugs.skip=true
count=$(${GREP} -c '\[ERROR\]' "${logfile}") count=$(${GREP} -c '\[ERROR\]' "${logfile}")
if [[ ${count} -gt 0 ]]; then if [[ ${count} -gt 0 ]]; then
@ -458,7 +470,7 @@ function shadedjars_rebuild
$(maven_executor) clean verify -fae --batch-mode \ $(maven_executor) clean verify -fae --batch-mode \
-pl hbase-shaded/hbase-shaded-check-invariants -am \ -pl hbase-shaded/hbase-shaded-check-invariants -am \
-Dtest=NoUnitTests -DHBasePatchProcess -Prelease \ -Dtest=NoUnitTests -DHBasePatchProcess -Prelease \
-Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dspotbugs.skip=true
count=$(${GREP} -c '\[ERROR\]' "${logfile}") count=$(${GREP} -c '\[ERROR\]' "${logfile}")
if [[ ${count} -gt 0 ]]; then if [[ ${count} -gt 0 ]]; then

6
dev-support/jenkins_precommit_github_yetus.sh
View File

@ -104,14 +104,14 @@ YETUS_ARGS+=("--reapermode=kill")
# with other jobs on systemd-enabled machines # with other jobs on systemd-enabled machines
YETUS_ARGS+=("--proclimit=10000") YETUS_ARGS+=("--proclimit=10000")
YETUS_ARGS+=("--dockermemlimit=20g") YETUS_ARGS+=("--dockermemlimit=20g")
# -1 findbugs issues that show up prior to the patch being applied # -1 spotbugs issues that show up prior to the patch being applied
YETUS_ARGS+=("--findbugs-strict-precheck") YETUS_ARGS+=("--spotbugs-strict-precheck")
# rsync these files back into the archive dir # rsync these files back into the archive dir
YETUS_ARGS+=("--archive-list=${ARCHIVE_PATTERN_LIST}") YETUS_ARGS+=("--archive-list=${ARCHIVE_PATTERN_LIST}")
# URL for user-side presentation in reports and such to our artifacts # URL for user-side presentation in reports and such to our artifacts
YETUS_ARGS+=("--build-url-artifacts=${BUILD_URL_ARTIFACTS}") YETUS_ARGS+=("--build-url-artifacts=${BUILD_URL_ARTIFACTS}")
# plugins to enable # plugins to enable
YETUS_ARGS+=("--plugins=${PLUGINS}") YETUS_ARGS+=("--plugins=${PLUGINS},-findbugs")
# run in docker mode and specifically point to our # run in docker mode and specifically point to our
# Dockerfile since we don't want to use the auto-pulled version. # Dockerfile since we don't want to use the auto-pulled version.
YETUS_ARGS+=("--docker") YETUS_ARGS+=("--docker")

0
dev-support/findbugs-exclude.xml → dev-support/spotbugs-exclude.xml
View File

16
hbase-archetypes/pom.xml
View File

@ -49,11 +49,11 @@
configuration of the hbase/pom.xml file. This override specifies that configuration of the hbase/pom.xml file. This override specifies that
the excluded-filter-file is found TWO levels up from a grandchild project. --> the excluded-filter-file is found TWO levels up from a grandchild project. -->
<plugin> <plugin>
<groupId>org.codehaus.mojo</groupId> <groupId>com.github.spotbugs</groupId>
<artifactId>findbugs-maven-plugin</artifactId> <artifactId>spotbugs-maven-plugin</artifactId>
<configuration> <configuration>
<excludeFilterFile>${project.basedir}/../../dev-support/findbugs-exclude.xml</excludeFilterFile> <excludeFilterFile>${project.basedir}/../../dev-support/spotbugs-exclude.xml</excludeFilterFile>
<findbugsXmlOutput>true</findbugsXmlOutput> <spotbugsXmlOutput>true</spotbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<effort>Max</effort> <effort>Max</effort>
</configuration> </configuration>
@ -64,16 +64,16 @@
<!-- Special configuration for findbugs just in the parent, emulating the setup in <!-- Special configuration for findbugs just in the parent, emulating the setup in
hbase/pom.xml. Note that exclude-file-filter is found ONE level up from this project. --> hbase/pom.xml. Note that exclude-file-filter is found ONE level up from this project. -->
<plugin> <plugin>
<groupId>org.codehaus.mojo</groupId> <groupId>com.github.spotbugs</groupId>
<artifactId>findbugs-maven-plugin</artifactId> <artifactId>spotbugs-maven-plugin</artifactId>
<executions> <executions>
<execution> <execution>
<inherited>false</inherited> <inherited>false</inherited>
<goals> <goals>
<goal>findbugs</goal> <goal>spotbugs</goal>
</goals> </goals>
<configuration> <configuration>
<excludeFilterFile>${project.basedir}/../dev-support/findbugs-exclude.xml</excludeFilterFile> <excludeFilterFile>${project.basedir}/../dev-support/spotbugs-exclude.xml</excludeFilterFile>
</configuration> </configuration>
</execution> </execution>
</executions> </executions>

11
hbase-client/pom.xml
View File

@ -100,6 +100,12 @@
<artifactId>hbase-protocol</artifactId> <artifactId>hbase-protocol</artifactId>
</dependency> </dependency>
<!-- General dependencies --> <!-- General dependencies -->
<dependency>
<groupId>com.github.stephenc.findbugs</groupId>
<artifactId>findbugs-annotations</artifactId>
<scope>compile</scope>
<optional>true</optional>
</dependency>
<dependency> <dependency>
<groupId>commons-codec</groupId> <groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId> <artifactId>commons-codec</artifactId>
@ -200,11 +206,6 @@
</property> </property>
</activation> </activation>
<dependencies> <dependencies>
<dependency>
<groupId>com.github.stephenc.findbugs</groupId>
<artifactId>findbugs-annotations</artifactId>
<optional>true</optional>
</dependency>
<dependency> <dependency>
<groupId>org.apache.hadoop</groupId> <groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-auth</artifactId> <artifactId>hadoop-auth</artifactId>

2
hbase-common/pom.xml
View File

@ -203,6 +203,8 @@
<dependency> <dependency>
<groupId>com.github.stephenc.findbugs</groupId> <groupId>com.github.stephenc.findbugs</groupId>
<artifactId>findbugs-annotations</artifactId> <artifactId>findbugs-annotations</artifactId>
<scope>compile</scope>
<optional>true</optional>
</dependency> </dependency>
<dependency> <dependency>
<groupId>org.mockito</groupId> <groupId>org.mockito</groupId>

2
hbase-examples/pom.xml
View File

@ -159,6 +159,8 @@
<dependency> <dependency>
<groupId>com.github.stephenc.findbugs</groupId> <groupId>com.github.stephenc.findbugs</groupId>
<artifactId>findbugs-annotations</artifactId> <artifactId>findbugs-annotations</artifactId>
<scope>compile</scope>
<optional>true</optional>
</dependency> </dependency>
<dependency> <dependency>
<groupId>org.apache.hbase</groupId> <groupId>org.apache.hbase</groupId>

2
hbase-hbtop/pom.xml
View File

@ -52,6 +52,8 @@
<dependency> <dependency>
<groupId>com.github.stephenc.findbugs</groupId> <groupId>com.github.stephenc.findbugs</groupId>
<artifactId>findbugs-annotations</artifactId> <artifactId>findbugs-annotations</artifactId>
<scope>compile</scope>
<optional>true</optional>
</dependency> </dependency>
<dependency> <dependency>
<groupId>org.slf4j</groupId> <groupId>org.slf4j</groupId>

12
hbase-http/pom.xml
View File

@ -105,11 +105,6 @@
</execution> </execution>
</executions> </executions>
</plugin> </plugin>
<!-- Run findbugs -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
</plugin>
<!-- Testing plugins --> <!-- Testing plugins -->
<plugin> <plugin>
<artifactId>maven-surefire-plugin</artifactId> <artifactId>maven-surefire-plugin</artifactId>
@ -214,7 +209,12 @@
<groupId>javax.ws.rs</groupId> <groupId>javax.ws.rs</groupId>
<artifactId>javax.ws.rs-api</artifactId> <artifactId>javax.ws.rs-api</artifactId>
</dependency> </dependency>
<dependency>
<groupId>com.github.stephenc.findbugs</groupId>
<artifactId>findbugs-annotations</artifactId>
<scope>compile</scope>
<optional>true</optional>
</dependency>
<!-- Test dependencies --> <!-- Test dependencies -->
<dependency> <dependency>
<groupId>org.apache.kerby</groupId> <groupId>org.apache.kerby</groupId>

11
hbase-mapreduce/pom.xml
View File

@ -199,6 +199,12 @@
<artifactId>hbase-replication</artifactId> <artifactId>hbase-replication</artifactId>
</dependency> </dependency>
<!-- General dependencies --> <!-- General dependencies -->
<dependency>
<groupId>com.github.stephenc.findbugs</groupId>
<artifactId>findbugs-annotations</artifactId>
<scope>compile</scope>
<optional>true</optional>
</dependency>
<dependency> <dependency>
<groupId>org.apache.hadoop</groupId> <groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-mapreduce-client-jobclient</artifactId> <artifactId>hadoop-mapreduce-client-jobclient</artifactId>
@ -272,11 +278,6 @@
</property> </property>
</activation> </activation>
<dependencies> <dependencies>
<dependency>
<groupId>com.github.stephenc.findbugs</groupId>
<artifactId>findbugs-annotations</artifactId>
<optional>true</optional>
</dependency>
<dependency> <dependency>
<groupId>org.apache.hadoop</groupId> <groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-common</artifactId> <artifactId>hadoop-common</artifactId>

1
hbase-procedure/pom.xml
View File

@ -97,6 +97,7 @@
<groupId>com.github.stephenc.findbugs</groupId> <groupId>com.github.stephenc.findbugs</groupId>
<artifactId>findbugs-annotations</artifactId> <artifactId>findbugs-annotations</artifactId>
<scope>compile</scope> <scope>compile</scope>
<optional>true</optional>
</dependency> </dependency>
<dependency> <dependency>
<groupId>junit</groupId> <groupId>junit</groupId>

2
hbase-protocol-shaded/pom.xml
View File

@ -178,7 +178,7 @@
<exclude>org.slf4j:slf4j-api</exclude> <exclude>org.slf4j:slf4j-api</exclude>
<exclude>org.apache.yetus:audience-annotations</exclude> <exclude>org.apache.yetus:audience-annotations</exclude>
<exclude>com.github.stephenc.fingbugs:*</exclude> <exclude>com.github.stephenc.fingbugs:*</exclude>
<exclude></exclude> <exclude>com.github.spotbugs:*</exclude>
</excludes> </excludes>
</artifactSet> </artifactSet>
</configuration> </configuration>

7
hbase-rest/pom.xml
View File

@ -362,9 +362,10 @@
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
<dependency> <dependency>
<groupId>com.github.stephenc.findbugs</groupId> <groupId>com.github.stephenc.findbugs</groupId>
<artifactId>findbugs-annotations</artifactId> <artifactId>findbugs-annotations</artifactId>
<optional>true</optional> <scope>compile</scope>
<optional>true</optional>
</dependency> </dependency>
<!--Test--> <!--Test-->
<dependency> <dependency>

19
hbase-server/pom.xml
View File

@ -72,6 +72,13 @@
</testResource> </testResource>
</testResources> </testResources>
<plugins> <plugins>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<maxHeap>2048</maxHeap>
</configuration>
</plugin>
<!-- licensing info from our bundled works --> <!-- licensing info from our bundled works -->
<plugin> <plugin>
<groupId>org.apache.maven.plugins</groupId> <groupId>org.apache.maven.plugins</groupId>
@ -210,11 +217,6 @@
</execution> </execution>
</executions> </executions>
</plugin> </plugin>
<!-- Run findbugs -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
</plugin>
<!-- Testing plugins --> <!-- Testing plugins -->
<plugin> <plugin>
<artifactId>maven-surefire-plugin</artifactId> <artifactId>maven-surefire-plugin</artifactId>
@ -375,9 +377,10 @@
</dependency> </dependency>
<!-- General dependencies --> <!-- General dependencies -->
<dependency> <dependency>
<groupId>com.github.stephenc.findbugs</groupId> <groupId>com.github.stephenc.findbugs</groupId>
<artifactId>findbugs-annotations</artifactId> <artifactId>findbugs-annotations</artifactId>
<optional>true</optional> <scope>compile</scope>
<optional>true</optional>
</dependency> </dependency>
<dependency> <dependency>
<groupId>com.github.ben-manes.caffeine</groupId> <groupId>com.github.ben-manes.caffeine</groupId>

3
hbase-shaded/hbase-shaded-check-invariants/pom.xml
View File

@ -119,7 +119,8 @@
<exclude>commons-logging:*</exclude> <exclude>commons-logging:*</exclude>
<!-- annotations that never change --> <!-- annotations that never change -->
<exclude>com.google.code.findbugs:*</exclude> <exclude>com.google.code.findbugs:*</exclude>
<exclude>com.github.stephenc.findbugs:*</exclude> <exclude>com.github.stephenc.fingbugs:*</exclude>
<exclude>com.github.spotbugs:*</exclude>
<!-- We leave HTrace as an unshaded dependnecy on purpose so that tracing within a JVM will work --> <!-- We leave HTrace as an unshaded dependnecy on purpose so that tracing within a JVM will work -->
<exclude>org.apache.htrace:*</exclude> <exclude>org.apache.htrace:*</exclude>
<!-- Our public API requires Hadoop at runtime to work --> <!-- Our public API requires Hadoop at runtime to work -->

7
hbase-shaded/hbase-shaded-client-byo-hadoop/pom.xml
View File

@ -73,9 +73,10 @@
</activation> </activation>
<dependencies> <dependencies>
<dependency> <dependency>
<groupId>com.github.stephenc.findbugs</groupId> <groupId>com.github.stephenc.findbugs</groupId>
<artifactId>findbugs-annotations</artifactId> <artifactId>findbugs-annotations</artifactId>
<optional>true</optional> <scope>compile</scope>
<optional>true</optional>
</dependency> </dependency>
<dependency> <dependency>
<groupId>org.apache.hadoop</groupId> <groupId>org.apache.hadoop</groupId>

3
hbase-shaded/hbase-shaded-client/pom.xml
View File

@ -67,7 +67,8 @@
<exclude>org.apache.hbase:hbase-resource-bundle</exclude> <exclude>org.apache.hbase:hbase-resource-bundle</exclude>
<exclude>org.slf4j:*</exclude> <exclude>org.slf4j:*</exclude>
<exclude>com.google.code.findbugs:*</exclude> <exclude>com.google.code.findbugs:*</exclude>
<exclude>com.github.stephenc.findbugs:*</exclude> <exclude>com.github.stephenc.fingbugs:*</exclude>
<exclude>com.github.spotbugs:*</exclude>
<exclude>org.apache.htrace:*</exclude> <exclude>org.apache.htrace:*</exclude>
<exclude>org.apache.yetus:*</exclude> <exclude>org.apache.yetus:*</exclude>
<exclude>log4j:*</exclude> <exclude>log4j:*</exclude>

3
hbase-shaded/hbase-shaded-testing-util/pom.xml
View File

@ -184,7 +184,8 @@
<exclude>org.apache.hbase:hbase-resource-bundle</exclude> <exclude>org.apache.hbase:hbase-resource-bundle</exclude>
<exclude>org.slf4j:*</exclude> <exclude>org.slf4j:*</exclude>
<exclude>com.google.code.findbugs:*</exclude> <exclude>com.google.code.findbugs:*</exclude>
<exclude>com.github.stephenc.findbugs:*</exclude> <exclude>com.github.stephenc.fingbugs:*</exclude>
<exclude>com.github.spotbugs:*</exclude>
<exclude>org.apache.htrace:*</exclude> <exclude>org.apache.htrace:*</exclude>
<exclude>org.apache.yetus:*</exclude> <exclude>org.apache.yetus:*</exclude>
<exclude>log4j:*</exclude> <exclude>log4j:*</exclude>

3
hbase-shaded/hbase-shaded-with-hadoop-check-invariants/pom.xml
View File

@ -108,7 +108,8 @@
<exclude>commons-logging:*</exclude> <exclude>commons-logging:*</exclude>
<!-- annotations that never change --> <!-- annotations that never change -->
<exclude>com.google.code.findbugs:*</exclude> <exclude>com.google.code.findbugs:*</exclude>
<exclude>com.github.stephenc.findbugs:*</exclude> <exclude>com.github.stephenc.fingbugs:*</exclude>
<exclude>com.github.spotbugs:*</exclude>
<!-- We leave HTrace as an unshaded dependnecy on purpose so that tracing within a JVM will work --> <!-- We leave HTrace as an unshaded dependnecy on purpose so that tracing within a JVM will work -->
<exclude>org.apache.htrace:*</exclude> <exclude>org.apache.htrace:*</exclude>
<!-- NB we don't exclude Hadoop from this check here, because the assumption is any needed classes <!-- NB we don't exclude Hadoop from this check here, because the assumption is any needed classes

3
hbase-shaded/pom.xml
View File

@ -147,7 +147,8 @@
<exclude>org.apache.hbase:hbase-resource-bundle</exclude> <exclude>org.apache.hbase:hbase-resource-bundle</exclude>
<exclude>org.slf4j:*</exclude> <exclude>org.slf4j:*</exclude>
<exclude>com.google.code.findbugs:*</exclude> <exclude>com.google.code.findbugs:*</exclude>
<exclude>com.github.stephenc.findbugs:*</exclude> <exclude>com.github.stephenc.fingbugs:*</exclude>
<exclude>com.github.spotbugs:*</exclude>
<exclude>org.apache.htrace:*</exclude> <exclude>org.apache.htrace:*</exclude>
<exclude>org.apache.yetus:*</exclude> <exclude>org.apache.yetus:*</exclude>
<exclude>log4j:*</exclude> <exclude>log4j:*</exclude>

5
hbase-shell/pom.xml
View File

@ -111,11 +111,6 @@
</executions> </executions>
</plugin> </plugin>
<!-- General plugins --> <!-- General plugins -->
<!-- Run findbugs -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
</plugin>
<plugin> <plugin>
<groupId>net.revelc.code</groupId> <groupId>net.revelc.code</groupId>
<artifactId>warbucks-maven-plugin</artifactId> <artifactId>warbucks-maven-plugin</artifactId>

6
hbase-thrift/pom.xml
View File

@ -232,6 +232,12 @@
<groupId>org.eclipse.jetty</groupId> <groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-util</artifactId> <artifactId>jetty-util</artifactId>
</dependency> </dependency>
<dependency>
<groupId>com.github.stephenc.findbugs</groupId>
<artifactId>findbugs-annotations</artifactId>
<scope>compile</scope>
<optional>true</optional>
</dependency>
<dependency> <dependency>
<!--For JspC used in ant task--> <!--For JspC used in ant task-->
<groupId>org.glassfish.web</groupId> <groupId>org.glassfish.web</groupId>

12
hbase-zookeeper/pom.xml
View File

@ -61,11 +61,6 @@
<skipAssembly>true</skipAssembly> <skipAssembly>true</skipAssembly>
</configuration> </configuration>
</plugin> </plugin>
<!-- Run findbugs -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
</plugin>
<plugin> <plugin>
<groupId>org.apache.maven.plugins</groupId> <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId> <artifactId>maven-checkstyle-plugin</artifactId>
@ -130,9 +125,10 @@
</dependency> </dependency>
<!-- General dependencies --> <!-- General dependencies -->
<dependency> <dependency>
<groupId>com.github.stephenc.findbugs</groupId> <groupId>com.github.stephenc.findbugs</groupId>
<artifactId>findbugs-annotations</artifactId> <artifactId>findbugs-annotations</artifactId>
<optional>true</optional> <scope>compile</scope>
<optional>true</optional>
</dependency> </dependency>
<dependency> <dependency>
<groupId>org.apache.commons</groupId> <groupId>org.apache.commons</groupId>

50
pom.xml
View File

@ -791,13 +791,12 @@
<version>${buildnumber.maven.version}</version> <version>${buildnumber.maven.version}</version>
</plugin> </plugin>
<plugin> <plugin>
<groupId>org.codehaus.mojo</groupId> <groupId>com.github.spotbugs</groupId>
<artifactId>findbugs-maven-plugin</artifactId> <artifactId>spotbugs-maven-plugin</artifactId>
<version>${findbugs.maven.version}</version> <version>${spotbugs.maven.version}</version>
<!--NOTE: Findbugs 3.0.0 requires jdk7-->
<configuration> <configuration>
<excludeFilterFile>${project.basedir}/../dev-support/findbugs-exclude.xml</excludeFilterFile> <excludeFilterFile>${project.basedir}/../dev-support/spotbugs-exclude.xml</excludeFilterFile>
<findbugsXmlOutput>true</findbugsXmlOutput> <spotbugsXmlOutput>true</spotbugsXmlOutput>
<xmlOutput>true</xmlOutput> <xmlOutput>true</xmlOutput>
<effort>Max</effort> <effort>Max</effort>
</configuration> </configuration>
@ -1256,19 +1255,19 @@
</transformationSets> </transformationSets>
</configuration> </configuration>
</plugin> </plugin>
<!-- Special configuration for findbugs just in the parent so <!-- Special configuration for spotbugs just in the parent so
the filter file location can be more general (see definition in pluginManagement) --> the filter file location can be more general (see definition in pluginManagement) -->
<plugin> <plugin>
<groupId>org.codehaus.mojo</groupId> <groupId>com.github.spotbugs</groupId>
<artifactId>findbugs-maven-plugin</artifactId> <artifactId>spotbugs-maven-plugin</artifactId>
<executions> <executions>
<execution> <execution>
<inherited>false</inherited> <inherited>false</inherited>
<goals> <goals>
<goal>findbugs</goal> <goal>spotbugs</goal>
</goals> </goals>
<configuration> <configuration>
<excludeFilterFile>${basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile> <excludeFilterFile>${basedir}/dev-support/spotbugs-exclude.xml</excludeFilterFile>
</configuration> </configuration>
</execution> </execution>
</executions> </executions>
@ -1548,8 +1547,6 @@
<checkstyle.version>8.28</checkstyle.version> <checkstyle.version>8.28</checkstyle.version>
<exec.maven.version>1.6.0</exec.maven.version> <exec.maven.version>1.6.0</exec.maven.version>
<error-prone.version>2.3.4</error-prone.version> <error-prone.version>2.3.4</error-prone.version>
<findbugs-annotations>1.3.9-1</findbugs-annotations>
<findbugs.maven.version>3.0.4</findbugs.maven.version>
<jamon.plugin.version>2.4.2</jamon.plugin.version> <jamon.plugin.version>2.4.2</jamon.plugin.version>
<lifecycle.mapping.version>1.0.0</lifecycle.mapping.version> <lifecycle.mapping.version>1.0.0</lifecycle.mapping.version>
<maven.antrun.version>1.8</maven.antrun.version> <maven.antrun.version>1.8</maven.antrun.version>
@ -1559,7 +1556,9 @@
<maven.warbucks.version>1.1.0</maven.warbucks.version> <maven.warbucks.version>1.1.0</maven.warbucks.version>
<maven.project.info.report.version>2.9</maven.project.info.report.version> <maven.project.info.report.version>2.9</maven.project.info.report.version>
<os.maven.version>1.5.0.Final</os.maven.version> <os.maven.version>1.5.0.Final</os.maven.version>
<spotbugs.version>3.1.11</spotbugs.version> <findbugs-annotations.version>1.3.9-1</findbugs-annotations.version>
<spotbugs.version>3.1.12</spotbugs.version>
<spotbugs.maven.version>3.1.12.2</spotbugs.maven.version>
<surefire.version>3.0.0-M4</surefire.version> <surefire.version>3.0.0-M4</surefire.version>
<wagon.ssh.version>2.12</wagon.ssh.version> <wagon.ssh.version>2.12</wagon.ssh.version>
<xml.maven.version>1.0.1</xml.maven.version> <xml.maven.version>1.0.1</xml.maven.version>
@ -1890,7 +1889,7 @@
<dependency> <dependency>
<groupId>com.github.stephenc.findbugs</groupId> <groupId>com.github.stephenc.findbugs</groupId>
<artifactId>findbugs-annotations</artifactId> <artifactId>findbugs-annotations</artifactId>
<version>${findbugs-annotations}</version> <version>${findbugs-annotations.version}</version>
</dependency> </dependency>
<!-- General dependencies --> <!-- General dependencies -->
<dependency> <dependency>
@ -2382,25 +2381,6 @@
<build> <build>
<pluginManagement> <pluginManagement>
<plugins> <plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
<version>${findbugs.maven.version}</version>
<!--NOTE: Findbugs 3.0.0 requires jdk7-->
<configuration>
<excludeFilterFile>${project.basedir}/../dev-support/findbugs-exclude.xml</excludeFilterFile>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput>
<effort>Max</effort>
</configuration>
<dependencies>
<dependency>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs</artifactId>
<version>${spotbugs.version}</version>
</dependency>
</dependencies>
</plugin>
</plugins> </plugins>
</pluginManagement> </pluginManagement>
</build> </build>
@ -3772,7 +3752,7 @@
<maven.javadoc.skip>true</maven.javadoc.skip> <maven.javadoc.skip>true</maven.javadoc.skip>
<enforcer.skip>true</enforcer.skip> <enforcer.skip>true</enforcer.skip>
<checkstyle.skip>true</checkstyle.skip> <checkstyle.skip>true</checkstyle.skip>
<findbugs.skip>true</findbugs.skip> <spotbugs.skip>true</spotbugs.skip>
<warbucks.skip>true</warbucks.skip> <warbucks.skip>true</warbucks.skip>
</properties> </properties>
</profile> </profile>