HBASE-23278 Add a table-level compaction progress display on the UI (#816)

Signed-off-by: Guangxu Cheng <gxcheng@apache.org>

hbase-server/src/main/resources/hbase-webapps/master/table.jsp

@@ -22,6 +22,7 @@
          import="static org.apache.commons.lang3.StringEscapeUtils.escapeXml"
          import="java.util.ArrayList"
          import="java.util.Collection"
+         import="java.util.HashMap"
          import="java.util.LinkedHashMap"
          import="java.util.List"
          import="java.util.Map"
@@ -62,6 +63,8 @@
 <%@ page import="org.apache.hadoop.hbase.RegionMetrics" %>
 <%@ page import="org.apache.hadoop.hbase.Size" %>
 <%@ page import="org.apache.hadoop.hbase.RegionMetricsBuilder" %>
+<%@ page import="org.apache.hadoop.hbase.master.assignment.RegionStates" %>
+<%@ page import="org.apache.hadoop.hbase.master.RegionState" %>
 <%!
   /**
    * @return An empty region load stamped with the passed in <code>regionInfo</code>
@@ -136,10 +139,7 @@ if (fqtn != null && master.isInitialized()) {
     try {
       table = master.getConnection().getTable(TableName.valueOf(fqtn));
       if (table.getTableDescriptor().getRegionReplication() > 1) {
-    tableHeader = "<h2>Table Regions</h2><table id=\"tableRegionTable\" class=\"tablesorter table table-striped\" style=\"table-layout: fixed; word-wrap: break-word;\"><thead><tr><th>Name</th><th>Region Server</th><th>ReadRequests</th><th>WriteRequests</th><th>StorefileSize</th><th>Num.Storefiles</th><th>MemSize</th><th>Locality</th><th>Start Key</th><th>End Key</th><th>ReplicaID</th></tr></thead>";
         withReplica = true;
-  } else {
-    tableHeader = "<h2>Table Regions</h2><table id=\"tableRegionTable\" class=\"tablesorter table table-striped\" style=\"table-layout: fixed; word-wrap: break-word;\"><thead><tr><th>Name</th><th>Region Server</th><th>ReadRequests</th><th>WriteRequests</th><th>StorefileSize</th><th>Num.Storefiles</th><th>MemSize</th><th>Locality</th><th>Start Key</th><th>End Key</th></tr></thead>";
       }
       if ( !readOnly && action != null ) {
 %>
@@ -195,7 +195,40 @@ if (fqtn != null && master.isInitialized()) {
     <%
       if(fqtn.equals(TableName.META_TABLE_NAME.getNameAsString())) {
     %>
-<%= tableHeader %>
+    <h2>Table Regions</h2>
+    <div class="tabbable">
+      <ul class="nav nav-pills">
+        <li class="active">
+          <a href="#metaTab_baseStats" data-toggle="tab">Base Stats</a>
+        </li>
+        <li class="">
+          <a href="#metaTab_compactStats" data-toggle="tab">Compactions</a>
+        </li>
+      </ul>
+      <div class="tab-content" style="padding-bottom: 9px; border-bottom: 1px solid #ddd;">
+        <div class="tab-pane active" id="metaTab_baseStats">
+          <table id="tableRegionTable" class="tablesorter table table-striped">
+            <thead>
+            <tr>
+              <th>Name</th>
+              <th>Region Server</th>
+              <th>ReadRequests</th>
+              <th>WriteRequests</th>
+              <th>StorefileSize</th>
+              <th>Num.Storefiles</th>
+              <th>MemSize</th>
+              <th>Locality</th>
+              <th>Start Key</th>
+              <th>End Key</th>
+              <%
+                if (withReplica) {
+              %>
+              <th>ReplicaID</th>
+              <%
+                }
+              %>
+            </tr>
+            </thead>
             <tbody>
             <%
               // NOTE: Presumes meta with one or more replicas
@@ -211,7 +244,6 @@ if (fqtn != null && master.isInitialized()) {
                   String fileCount = "N/A";
                   String memSize = ZEROMB;
                   float locality = 0.0f;
-
                   if (metaLocation != null) {
                     ServerMetrics sl = master.getServerManager().getLoad(metaLocation);
                     // The host name portion should be safe, but I don't know how we handle IDNs so err on the side of failing safely.
@@ -259,7 +291,72 @@ if (fqtn != null && master.isInitialized()) {
             <%} %>
             </tbody>
           </table>
+        </div>
+        <div class="tab-pane" id="metaTab_compactStats">
+          <table id="metaTableCompactStatsTable" class="tablesorter table table-striped">
+            <thead>
+            <tr>
+              <th>Name</th>
+              <th>Region Server</th>
+              <th>Num. Compacting Cells</th>
+              <th>Num. Compacted Cells</th>
+              <th>Remaining Cells</th>
+              <th>Compaction Progress</th>
+            </tr>
+            </thead>
+            <tbody>
+            <%
+              // NOTE: Presumes meta with one or more replicas
+              for (int j = 0; j < numMetaReplicas; j++) {
+                RegionInfo meta = RegionReplicaUtil.getRegionInfoForReplica(
+                        RegionInfoBuilder.FIRST_META_REGIONINFO, j);
+                ServerName metaLocation = MetaTableLocator.waitMetaRegionLocation(master.getZooKeeper(), j, 1);
+                for (int i = 0; i < 1; i++) {
+                  String hostAndPort = "";
+                  long compactingCells = 0;
+                  long compactedCells = 0;
+                  String compactionProgress = "";
+                  if (metaLocation != null) {
+                    ServerMetrics sl = master.getServerManager().getLoad(metaLocation);
+                    hostAndPort = URLEncoder.encode(metaLocation.getHostname()) + ":" + master.getRegionServerInfoPort(metaLocation);
+                    if (sl != null) {
+                      Map<byte[], RegionMetrics> map = sl.getRegionMetrics();
+                      if (map.containsKey(meta.getRegionName())) {
+                        RegionMetrics load = map.get(meta.getRegionName());
+                        compactingCells = load.getCompactingCellCount();
+                        compactedCells = load.getCompactedCellCount();
+                        if (compactingCells > 0) {
+                          compactionProgress = String.format("%.2f", 100 * ((float)
+                                  compactedCells / compactingCells)) + "%";
+                        }
+                      }
+                    }
+                  }
+            %>
+            <tr>
+              <td><%= escapeXml(meta.getRegionNameAsString()) %></td>
+              <td><a href="http://<%= hostAndPort %>/rs-status/"><%= StringEscapeUtils.escapeHtml4(hostAndPort) %></a></td>
+              <td><%= String.format("%,1d", compactingCells)%></td>
+              <td><%= String.format("%,1d", compactedCells)%></td>
+              <td><%= String.format("%,1d", compactingCells - compactedCells)%></td>
+              <td><%= compactionProgress%></td>
+            </tr>
+            <%  } %>
+            <%} %>
+            </tbody>
+          </table>
+        </div>
+      </div>
+    </div>
     <%} else {
+      RegionStates states = master.getAssignmentManager().getRegionStates();
+      Map<RegionState.State, List<RegionInfo>> regionStates = states.getRegionByStateOfTable(table.getName());
+      Map<String, RegionState.State> stateMap = new HashMap<>();
+      for (RegionState.State regionState : regionStates.keySet()) {
+        for (RegionInfo regionInfo : regionStates.get(regionState)) {
+          stateMap.put(regionInfo.getEncodedName(), regionState);
+        }
+      }
       RegionLocator r = master.getConnection().getRegionLocator(table.getName());
       try { %>
     <h2>Table Attributes</h2>
@@ -434,6 +531,9 @@ if (fqtn != null && master.isInitialized()) {
       long totalSize = 0;
       long totalStoreFileCount = 0;
       long totalMemSize = 0;
+      long totalCompactingCells = 0;
+      long totalCompactedCells = 0;
+      String totalCompactionProgress = "";
       String totalMemSizeStr = ZEROMB;
       String totalSizeStr = ZEROMB;
       String urlRegionServer = null;
@@ -459,6 +559,8 @@ if (fqtn != null && master.isInitialized()) {
               totalStoreFileCount += regionMetrics.getStoreFileCount();
               totalMemSize += regionMetrics.getMemStoreSize().get(Size.Unit.MEGABYTE);
               totalStoreFileSizeMB += regionMetrics.getStoreFileSize().get(Size.Unit.MEGABYTE);
+              totalCompactingCells += regionMetrics.getCompactingCellCount();
+              totalCompactedCells += regionMetrics.getCompactedCellCount();
             } else {
               RegionMetrics load0 = getEmptyRegionMetrics(regionInfo);
               regionsToLoad.put(regionInfo, load0);
@@ -478,9 +580,23 @@ if (fqtn != null && master.isInitialized()) {
       if (totalMemSize > 0) {
         totalMemSizeStr = StringUtils.byteDesc(totalMemSize*1024l*1024);
       }
-
+      if (totalCompactingCells > 0) {
+        totalCompactionProgress = String.format("%.2f", 100 *
+                ((float) totalCompactedCells / totalCompactingCells)) + "%";
+      }
       if(regions != null && regions.size() > 0) { %>
     <h2>Table Regions</h2>
+    <div class="tabbable">
+      <ul class="nav nav-pills">
+        <li class="active">
+          <a href="#tab_baseStats" data-toggle="tab">Base Stats</a>
+        </li>
+        <li class="">
+          <a href="#tab_compactStats" data-toggle="tab">Compactions</a>
+        </li>
+      </ul>
+      <div class="tab-content" style="padding-bottom: 9px; border-bottom: 1px solid #ddd;">
+        <div class="tab-pane active" id="tab_baseStats">
           <table id="regionServerDetailsTable" class="tablesorter table table-striped">
             <thead>
             <tr>
@@ -494,6 +610,7 @@ if (fqtn != null && master.isInitialized()) {
               <th>Locality</th>
               <th>Start Key</th>
               <th>End Key</th>
+              <th>Region State</th>
               <%
                 if (withReplica) {
               %>
@@ -501,10 +618,9 @@ if (fqtn != null && master.isInitialized()) {
               <%
                 }
               %>
-</thead>
             </tr>
+            </thead>
             <tbody>
-
             <%
               List<Map.Entry<RegionInfo, RegionMetrics>> entryList = new ArrayList<>(regionsToLoad.entrySet());
               numRegions = regions.size();
@@ -523,6 +639,7 @@ if (fqtn != null && master.isInitialized()) {
                 String fileCount = "N/A";
                 String memSize = ZEROMB;
                 float locality = 0.0f;
+                String state = "N/A";
                 if (load != null) {
                   readReq = String.format("%,1d", load.getReadRequestCount());
                   writeReq = String.format("%,1d", load.getWriteRequestCount());
@@ -537,7 +654,9 @@ if (fqtn != null && master.isInitialized()) {
                   }
                   locality = load.getDataLocality();
                 }
-
+                if (stateMap.containsKey(regionInfo.getEncodedName())) {
+                  state = stateMap.get(regionInfo.getEncodedName()).toString();
+                }
                 if (addr != null) {
                   ServerMetrics sl = master.getServerManager().getLoad(addr);
                   // This port might be wrong if RS actually ended up using something else.
@@ -580,6 +699,7 @@ if (fqtn != null && master.isInitialized()) {
               <td><%= locality%></td>
               <td><%= escapeXml(Bytes.toStringBinary(regionInfo.getStartKey()))%></td>
               <td><%= escapeXml(Bytes.toStringBinary(regionInfo.getEndKey()))%></td>
+              <td><%= state%></td>
               <%
                 if (withReplica) {
               %>
@@ -599,6 +719,79 @@ if (fqtn != null && master.isInitialized()) {
             only <b><%= numRegionsRendered %></b> regions are displayed here, <a href="<%= allRegionsUrl %>">click
               here</a> to see all regions.</p>
           <% } %>
+        </div>
+        <div class="tab-pane" id="tab_compactStats">
+          <table id="tableCompactStatsTable" class="tablesorter table table-striped">
+            <thead>
+            <tr>
+              <th>Name(<%= String.format("%,1d", regions.size())%>)</th>
+              <th>Region Server</th>
+              <th>Num. Compacting Cells<br>(<%= String.format("%,1d", totalCompactingCells)%>)</th>
+              <th>Num. Compacted Cells<br>(<%= String.format("%,1d", totalCompactedCells)%>)</th>
+              <th>Remaining Cells<br>(<%= String.format("%,1d", totalCompactingCells-totalCompactedCells)%>)</th>
+              <th>Compaction Progress<br>(<%= totalCompactionProgress %>)</th>
+            </tr>
+            </thead>
+            <tbody>
+            <%
+              numRegionsRendered = 0;
+              for (Map.Entry<RegionInfo, RegionMetrics> hriEntry : entryList) {
+                RegionInfo regionInfo = hriEntry.getKey();
+                ServerName addr = regionsToServer.get(regionInfo);
+                RegionMetrics load = hriEntry.getValue();
+                long compactingCells = 0;
+                long compactedCells = 0;
+                String compactionProgress = "";
+                if (load != null) {
+                  compactingCells = load.getCompactingCellCount();
+                  compactedCells = load.getCompactedCellCount();
+                  if (compactingCells > 0) {
+                    compactionProgress = String.format("%.2f", 100 * ((float)
+                            compactedCells / compactingCells)) + "%";
+                  }
+                }
+                if (addr != null) {
+                  // This port might be wrong if RS actually ended up using something else.
+                  urlRegionServer =
+                          "//" + URLEncoder.encode(addr.getHostname()) + ":" + master.getRegionServerInfoPort(addr) + "/rs-status";
+                }
+                if (numRegionsRendered < numRegionsToRender) {
+                  numRegionsRendered++;
+            %>
+            <tr>
+              <td><%= escapeXml(Bytes.toStringBinary(regionInfo.getRegionName())) %></td>
+              <%
+                if (urlRegionServer != null) {
+              %>
+              <td>
+                <a href="<%= urlRegionServer %>"><%= addr == null? "-": StringEscapeUtils.escapeHtml4(addr.getHostname().toString()) + ":" + master.getRegionServerInfoPort(addr) %></a>
+              </td>
+              <%
+              } else {
+              %>
+              <td class="undeployed-region">not deployed</td>
+              <%
+                }
+              %>
+              <td><%= String.format("%,1d", compactingCells)%></td>
+              <td><%= String.format("%,1d", compactedCells)%></td>
+              <td><%= String.format("%,1d", compactingCells - compactedCells)%></td>
+              <td><%= compactionProgress%></td>
+            </tr>
+            <% } %>
+            <% } %>
+            </tbody>
+          </table>
+          <% if (numRegions > numRegionsRendered) {
+            String allRegionsUrl = "?name=" + URLEncoder.encode(fqtn,"UTF-8") + "&numRegions=all";
+          %>
+          <p>This table has <b><%= numRegions %></b> regions in total, in order to improve the page load time,
+            only <b><%= numRegionsRendered %></b> regions are displayed here, <a href="<%= allRegionsUrl %>">click
+              here</a> to see all regions.</p>
+          <% } %>
+        </div>
+      </div>
+    </div>
     <h2>Regions by Region Server</h2>
     <%
       if (withReplica) {
@@ -832,6 +1025,20 @@ $(document).ready(function()
                     6: {sorter: 'filesize'}
                 }
             });
+            $("#tableCompactStatsTable").tablesorter({
+                headers: {
+                    2: {sorter: 'separator'},
+                    3: {sorter: 'separator'},
+                    4: {sorter: 'separator'}
+                }
+            });
+            $("#metaTableCompactStatsTable").tablesorter({
+                headers: {
+                    2: {sorter: 'separator'},
+                    3: {sorter: 'separator'},
+                    4: {sorter: 'separator'}
+                }
+            });
         }
     );
 </script>