Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-20770 WAL cleaner logs way too much; gets clogged when lots of work to do 

General log cleanup; setting stuff that can flood the log to TRACE.

Amending-Author: Andrew Purtell <apurtell@apache.org>
This commit is contained in:
Michael Stack 2018-06-23 23:29:11 -07:00 committed by Andrew Purtell
parent 4936750d3a
commit ccead1264c
4 changed files with 6 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClient.java
View File

@ -44,9 +44,7 @@ public class NettyHBaseSaslRpcClient extends AbstractHBaseSaslRpcClient {
public void setupSaslHandler(ChannelPipeline p) { public void setupSaslHandler(ChannelPipeline p) {
String qop = (String) saslClient.getNegotiatedProperty(Sasl.QOP); String qop = (String) saslClient.getNegotiatedProperty(Sasl.QOP);
if (LOG.isDebugEnabled()) { LOG.trace("SASL client context established. Negotiated QoP " + qop);
LOG.debug("SASL client context established. Negotiated QoP: " + qop);
}
if (qop == null || "auth".equalsIgnoreCase(qop)) { if (qop == null || "auth".equalsIgnoreCase(qop)) {
return; return;
} }

8
hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClientHandler.java
View File

@ -61,9 +61,7 @@ public class NettyHBaseSaslRpcClientHandler extends SimpleChannelInboundHandler<
} }
private void writeResponse(ChannelHandlerContext ctx, byte[] response) { private void writeResponse(ChannelHandlerContext ctx, byte[] response) {
if (LOG.isDebugEnabled()) { LOG.trace("Will send token of size " + response.length + " from initSASLContext.");
LOG.debug("Will send token of size " + response.length + " from initSASLContext.");
}
ctx.writeAndFlush( ctx.writeAndFlush(
ctx.alloc().buffer(4 + response.length).writeInt(response.length).writeBytes(response)); ctx.alloc().buffer(4 + response.length).writeInt(response.length).writeBytes(response));
} }
@ -109,9 +107,7 @@ public class NettyHBaseSaslRpcClientHandler extends SimpleChannelInboundHandler<
} }
return; return;
} }
if (LOG.isDebugEnabled()) { LOG.trace("Will read input token of size " + len + " for processing by initSASLContext");
LOG.debug("Will read input token of size " + len + " for processing by initSASLContext");
}
final byte[] challenge = new byte[len]; final byte[] challenge = new byte[len];
msg.readBytes(challenge); msg.readBytes(challenge);
byte[] response = ugi.doAs(new PrivilegedExceptionAction<byte[]>() { byte[] response = ugi.doAs(new PrivilegedExceptionAction<byte[]>() {

3
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/RegionLocationFinder.java
View File

@ -285,8 +285,7 @@ class RegionLocationFinder {
blockDistbn = cache.get(hri); blockDistbn = cache.get(hri);
return blockDistbn; return blockDistbn;
} else { } else {
LOG.debug("HDFSBlocksDistribution not found in cache for region " LOG.trace("HDFSBlocksDistribution not found in cache for region " + hri.getRegionNameAsString());
+ hri.getRegionNameAsString());
blockDistbn = internalGetTopBlockLocation(hri); blockDistbn = internalGetTopBlockLocation(hri);
cache.put(hri, blockDistbn); cache.put(hri, blockDistbn);
return blockDistbn; return blockDistbn;

6
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
View File

@ -292,9 +292,7 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
POOL.updatePool((long) (0.8 * getTimeUnit().toMillis(getPeriod()))); POOL.updatePool((long) (0.8 * getTimeUnit().toMillis(getPeriod())));
} }
} else { } else {
if (LOG.isTraceEnabled()) { LOG.trace("Cleaner chore disabled! Not cleaning.");
LOG.trace("Cleaner chore disabled! Not cleaning.");
}
} }
} }
@ -432,7 +430,7 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
@Override @Override
protected Boolean compute() { protected Boolean compute() {
LOG.debug("Cleaning under " + dir); LOG.trace("Cleaning under " + dir);
List<FileStatus> subDirs; List<FileStatus> subDirs;
final List<FileStatus> files; final List<FileStatus> files;
try { try {