Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-23588 : Cache index & bloom blocks on write (ADDENDUM) 

Signed-off-by: Anoop Sam John <anoopsamjohn@apache.org>
This commit is contained in:
Viraj Jasani 2020-01-06 11:29:29 +05:30
parent ab9766599d
commit cd870790b1
No known key found for this signature in database
GPG Key ID: E906DFF511D3E5DB
1 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
View File

@ -159,6 +159,8 @@ public class HStore implements Store, HeapSize, StoreConfigInformation, Propagat
private AtomicLong storeSize = new AtomicLong();
private AtomicLong totalUncompressedBytes = new AtomicLong();
private boolean cacheOnWriteLogged;
/**
* RWLock for store operations.
* Locked in shared mode when the list of component stores is looked at:
@ -338,6 +340,7 @@ public class HStore implements Store, HeapSize, StoreConfigInformation, Propagat
getColumnFamilyName(), memstore.getClass().getSimpleName(), policyName, verifyBulkLoads,
parallelPutCountPrintThreshold, family.getDataBlockEncoding(),
family.getCompressionType());
cacheOnWriteLogged = false;
}
/**
@ -1120,15 +1123,19 @@ public class HStore implements Store, HeapSize, StoreConfigInformation, Propagat
if (isCompaction) {
// Don't cache data on write on compactions, unless specifically configured to do so
writerCacheConf = new CacheConfig(cacheConf);
final boolean shouldCacheCompactedBlocksOnWrite = cacheConf
.shouldCacheCompactedBlocksOnWrite();
final boolean cacheCompactedBlocksOnWrite =
cacheConf.shouldCacheCompactedBlocksOnWrite();
// if data blocks are to be cached on write
// during compaction, we should forcefully
// cache index and bloom blocks as well
if (shouldCacheCompactedBlocksOnWrite) {
if (cacheCompactedBlocksOnWrite) {
writerCacheConf.enableCacheOnWrite();
LOG.info("cacheCompactedBlocksOnWrite is true, hence enabled cacheOnWrite for " +
"Data blocks, Index blocks and Bloom filter blocks");
if (!cacheOnWriteLogged) {
LOG.info("For Store {} , cacheCompactedBlocksOnWrite is true, hence enabled " +
"cacheOnWrite for Data blocks, Index blocks and Bloom filter blocks",
getColumnFamilyName());
cacheOnWriteLogged = true;
}
} else {
writerCacheConf.setCacheDataOnWrite(false);
}
@ -1137,8 +1144,11 @@ public class HStore implements Store, HeapSize, StoreConfigInformation, Propagat
final boolean shouldCacheDataOnWrite = cacheConf.shouldCacheDataOnWrite();
if (shouldCacheDataOnWrite) {
writerCacheConf.enableCacheOnWrite();
LOG.info("cacheDataOnWrite is true, hence enabled cacheOnWrite for " +
"Index blocks and Bloom filter blocks");
if (!cacheOnWriteLogged) {
LOG.info("For Store {} , cacheDataOnWrite is true, hence enabled cacheOnWrite for " +
"Index blocks and Bloom filter blocks", getColumnFamilyName());
cacheOnWriteLogged = true;
}
}
}
InetSocketAddress[] favoredNodes = null;