From d0e5ea1b87f4716eb7e7137d496f0192c87d38b6 Mon Sep 17 00:00:00 2001 From: Braavos <35978114+Braavos96@users.noreply.github.com> Date: Mon, 5 Aug 2019 02:29:51 +0100 Subject: [PATCH] HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes Co-authored-by: Jan Hentschel Signed-off-by: Jan Hentschel --- .../hadoop/hbase/util/TestByteRangeUtils.java | 72 +++++++++++++++++++ .../apache/hadoop/hbase/util/TestClasses.java | 64 +++++++++++++++++ 2 files changed, 136 insertions(+) create mode 100644 hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestByteRangeUtils.java create mode 100644 hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestClasses.java diff --git a/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestByteRangeUtils.java b/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestByteRangeUtils.java new file mode 100644 index 00000000000..813b32e7668 --- /dev/null +++ b/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestByteRangeUtils.java @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.util; + +import static org.junit.Assert.assertArrayEquals; +import static org.junit.Assert.assertEquals; + +import java.util.ArrayList; +import java.util.Arrays; + +import org.apache.hadoop.hbase.HBaseClassTestRule; +import org.apache.hadoop.hbase.testclassification.SmallTests; +import org.junit.ClassRule; +import org.junit.Test; +import org.junit.experimental.categories.Category; + +@Category({SmallTests.class}) +public class TestByteRangeUtils { + + @ClassRule + public static final HBaseClassTestRule CLASS_RULE = + HBaseClassTestRule.forClass(TestByteRangeUtils.class); + + @Test + public void testNumEqualPrefixBytes() { + assertEquals(0, ByteRangeUtils.numEqualPrefixBytes( + new SimpleByteRange(new byte[]{1, 2, 3}), + new SimpleByteRange(new byte[]{4, 5, 6}), 1)); + assertEquals(2, ByteRangeUtils.numEqualPrefixBytes( + new SimpleByteRange(new byte[]{1, 2, 3}), + new SimpleByteRange(new byte[]{0, 1, 2}), 1)); + } + + @Test + public void testCopyToNewArrays() { + assertEquals(new ArrayList<>(), + ByteRangeUtils.copyToNewArrays(null)); + assertArrayEquals(new byte[]{1, 2, 3}, + ByteRangeUtils.copyToNewArrays(new ArrayList<>(Arrays.asList( + new SimpleByteRange(new byte[]{1, 2, 3}), + new SimpleByteRange(new byte[]{4, 5, 6})))).get(0)); + assertArrayEquals(new byte[]{4, 5, 6}, + ByteRangeUtils.copyToNewArrays(new ArrayList<>(Arrays.asList( + new SimpleByteRange(new byte[]{1, 2, 3}), + new SimpleByteRange(new byte[]{4, 5, 6})))).get(1)); + } + + @Test + public void testFromArrays() { + assertEquals(new ArrayList<>(), ByteRangeUtils.fromArrays(null)); + assertEquals(new ArrayList<>(Arrays.asList( + new SimpleMutableByteRange(new byte[]{1, 2, 3}), + new SimpleMutableByteRange(new byte[]{4, 5, 6}))), + ByteRangeUtils.fromArrays(new ArrayList<>( + Arrays.asList(new byte[]{1, 2, 3}, new byte[]{4, 5, 6})))); + } +} diff --git a/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestClasses.java b/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestClasses.java new file mode 100644 index 00000000000..f2b1a542fef --- /dev/null +++ b/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestClasses.java @@ -0,0 +1,64 @@ +/* + * Copyright The Apache Software Foundation + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.util; + +import static org.junit.Assert.assertEquals; + +import org.apache.hadoop.hbase.HBaseClassTestRule; +import org.apache.hadoop.hbase.testclassification.SmallTests; +import org.junit.ClassRule; +import org.junit.Rule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.rules.ExpectedException; + +@Category({SmallTests.class}) +public class TestClasses { + + @Rule + public final ExpectedException thrown = ExpectedException.none(); + + @ClassRule + public static final HBaseClassTestRule CLASS_RULE = + HBaseClassTestRule.forClass(TestClasses.class); + + @Test + public void testExtendedForName() throws ClassNotFoundException { + assertEquals(int.class, Classes.extendedForName("int")); + assertEquals(long.class, Classes.extendedForName("long")); + assertEquals(char.class, Classes.extendedForName("char")); + assertEquals(byte.class, Classes.extendedForName("byte")); + assertEquals(short.class, Classes.extendedForName("short")); + assertEquals(float.class, Classes.extendedForName("float")); + assertEquals(double.class, Classes.extendedForName("double")); + assertEquals(boolean.class, Classes.extendedForName("boolean")); + + thrown.expect(ClassNotFoundException.class); + Classes.extendedForName("foo"); + } + + @Test + public void testStringify() { + assertEquals("", Classes.stringify(new Class[0])); + assertEquals("NULL", Classes.stringify(null)); + assertEquals("java.lang.String,java.lang.Integer", + Classes.stringify(new Class[]{String.class, Integer.class})); + } +}