HBASE-2824 A filter that randomly includes rows based on a configured chance; Clarify test

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1067235 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Andrew Kyle Purtell 2011-02-04 17:35:51 +00:00
parent 1aa394d882
commit d1176f5791
1 changed files with 5 additions and 5 deletions

View File

@ -30,12 +30,12 @@ import junit.framework.TestCase;
import org.apache.hadoop.hbase.util.Bytes; import org.apache.hadoop.hbase.util.Bytes;
public class TestRandomRowFilter extends TestCase { public class TestRandomRowFilter extends TestCase {
protected RandomRowFilter halfChanceFilter; protected RandomRowFilter quarterChanceFilter;
@Override @Override
protected void setUp() throws Exception { protected void setUp() throws Exception {
super.setUp(); super.setUp();
halfChanceFilter = new RandomRowFilter(0.25f); quarterChanceFilter = new RandomRowFilter(0.25f);
} }
/** /**
@ -47,7 +47,7 @@ public class TestRandomRowFilter extends TestCase {
int included = 0; int included = 0;
int max = 1000000; int max = 1000000;
for (int i = 0; i < max; i++) { for (int i = 0; i < max; i++) {
if (!halfChanceFilter.filterRowKey(Bytes.toBytes("row"), 0, Bytes if (!quarterChanceFilter.filterRowKey(Bytes.toBytes("row"), 0, Bytes
.toBytes("row").length)) { .toBytes("row").length)) {
included++; included++;
} }
@ -66,10 +66,10 @@ public class TestRandomRowFilter extends TestCase {
* @throws Exception * @throws Exception
*/ */
public void testSerialization() throws Exception { public void testSerialization() throws Exception {
RandomRowFilter newFilter = serializationTest(halfChanceFilter); RandomRowFilter newFilter = serializationTest(quarterChanceFilter);
// use epsilon float comparison // use epsilon float comparison
assertTrue("float should be equal", Math.abs(newFilter.getChance() assertTrue("float should be equal", Math.abs(newFilter.getChance()
- halfChanceFilter.getChance()) < 0.000001f); - quarterChanceFilter.getChance()) < 0.000001f);
} }
private RandomRowFilter serializationTest(RandomRowFilter filter) private RandomRowFilter serializationTest(RandomRowFilter filter)