Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-2851 Remove testDynamicBloom() unit test 

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@965678 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael Stack 2010-07-19 23:34:03 +00:00
parent b6282f5508
commit d1179f8829
2 changed files with 3 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGES.txt
View File

@ -442,6 +442,8 @@ Release 0.21.0 - Unreleased
HBASE-2846 Make rest server be same as thrift and avro servers
HBASE-1511 Pseudo distributed mode in LocalHBaseCluster
(Nicolas Spiegelberg via Stack)
HBASE-2851 Remove testDynamicBloom() unit test
(Nicolas Spiegelberg via Stack)
IMPROVEMENTS

45
src/test/java/org/apache/hadoop/hbase/util/TestByteBloomFilter.java
View File

@ -138,47 +138,4 @@ public class TestByteBloomFilter extends TestCase {
// test: foldFactor > log(max/actual)
}
public void testDynamicBloom() throws Exception {
int keyInterval = 1000;
float err = (float)0.01;
BitSet valid = new BitSet(keyInterval*4);
DynamicByteBloomFilter bf1 = new DynamicByteBloomFilter(keyInterval, err,
Hash.MURMUR_HASH);
bf1.allocBloom();
for (int i = 0; i < keyInterval*4; ++i) { // add
if (Math.random() > 0.5) {
bf1.add(Bytes.toBytes(i));
valid.set(i);
}
}
assertTrue(2 <= bf1.bloomCount() && bf1.bloomCount() <= 3);
// test serialization/deserialization
ByteArrayOutputStream metaOut = new ByteArrayOutputStream();
ByteArrayOutputStream dataOut = new ByteArrayOutputStream();
bf1.getMetaWriter().write(new DataOutputStream(metaOut));
bf1.getDataWriter().write(new DataOutputStream(dataOut));
ByteBuffer bb = ByteBuffer.wrap(dataOut.toByteArray());
DynamicByteBloomFilter newBf1 = new DynamicByteBloomFilter(
ByteBuffer.wrap(metaOut.toByteArray()));
int falsePositives = 0;
for (int i = 0; i < keyInterval*4; ++i) { // check
if (newBf1.contains(Bytes.toBytes(i), bb)) {
if (!valid.get(i)) ++falsePositives;
} else {
if (valid.get(i)) {
assert false;
}
}
}
// note that actualErr = err * bloomCount
// error rate should be roughly: (keyInterval*2)*(err*2), allow some tolerance
System.out.println("False positives: " + falsePositives);
assertTrue(falsePositives <= (keyInterval*5)*err);
}
}
}