Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-8448 RatioBasedCompactionPolicy (and derived ones) can select already-compacting files for compaction 

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1477391 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
sershe 2013-04-29 22:36:56 +00:00
parent efd752b5b4
commit d1f0efc81c
3 changed files with 18 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/ExploringCompactionPolicy.java
View File

@ -37,8 +37,6 @@ import org.apache.hadoop.hbase.regionserver.StoreFile;
@InterfaceAudience.Private
public class ExploringCompactionPolicy extends RatioBasedCompactionPolicy {
/** Computed number of files that are needed to assume compactions are stuck. */
private final long filesNeededToForce;
/**
* Constructor for ExploringCompactionPolicy.
@ -48,20 +46,17 @@ public class ExploringCompactionPolicy extends RatioBasedCompactionPolicy {
public ExploringCompactionPolicy(final Configuration conf,
final StoreConfigInformation storeConfigInfo) {
super(conf, storeConfigInfo);
filesNeededToForce = storeConfigInfo.getBlockingFileCount();
}
@Override
final ArrayList<StoreFile> applyCompactionPolicy(final ArrayList<StoreFile> candidates,
final boolean mayUseOffPeak) throws IOException {
final boolean mayUseOffPeak, final boolean mightBeStuck) throws IOException {
// Start off choosing nothing.
List<StoreFile> bestSelection = new ArrayList<StoreFile>(0);
List<StoreFile> smallest = new ArrayList<StoreFile>(0);
long bestSize = 0;
long smallestSize = Long.MAX_VALUE;
boolean mightBeStuck = candidates.size() >= filesNeededToForce;
// Consider every starting place.
for (int start = 0; start < candidates.size(); start++) {
// Consider every different sub list permutation in between start and end with min files.

31
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java
View File

@ -82,6 +82,12 @@ public class RatioBasedCompactionPolicy extends CompactionPolicy {
final boolean mayUseOffPeak, final boolean forceMajor) throws IOException {
// Preliminary compaction subject to filters
ArrayList<StoreFile> candidateSelection = new ArrayList<StoreFile>(candidateFiles);
// Stuck and not compacting enough (estimate). It is not guaranteed that we will be
// able to compact more if stuck and compacting, because ratio policy excludes some
// non-compacting files from consideration during compaction (see getCurrentEligibleFiles).
int futureFiles = filesCompacting.isEmpty() ? 0 : 1;
boolean mayBeStuck = (candidateFiles.size() - filesCompacting.size() + futureFiles)
>= storeConfigInfo.getBlockingFileCount();
candidateSelection = getCurrentEligibleFiles(candidateSelection, filesCompacting);
long cfTtl = this.storeConfigInfo.getStoreFileTtl();
if (!forceMajor) {
@ -110,18 +116,10 @@ public class RatioBasedCompactionPolicy extends CompactionPolicy {
if (!majorCompaction) {
// we're doing a minor compaction, let's see what files are applicable
candidateSelection = filterBulk(candidateSelection);
candidateSelection = applyCompactionPolicy(candidateSelection, mayUseOffPeak);
candidateSelection = applyCompactionPolicy(candidateSelection, mayUseOffPeak, mayBeStuck);
candidateSelection = checkMinFilesCriteria(candidateSelection);
}
candidateSelection = removeExcessFiles(candidateSelection, isUserCompaction, majorCompaction);
if (candidateSelection.size() == 0
&& candidateFiles.size() >= storeConfigInfo.getBlockingFileCount()) {
candidateSelection = new ArrayList<StoreFile>(candidateFiles);
candidateSelection
.subList(0, Math.max(0,candidateSelection.size() - comConf.getMinFilesToCompact()))
.clear();
}
CompactionRequest result = new CompactionRequest(candidateSelection);
result.setOffPeak(!candidateSelection.isEmpty() && !majorCompaction && mayUseOffPeak);
return result;
@ -261,8 +259,8 @@ public class RatioBasedCompactionPolicy extends CompactionPolicy {
* | | | | | | | | | | | |
* | | | | | | | | | | | |
*/
ArrayList<StoreFile> applyCompactionPolicy(
ArrayList<StoreFile> candidates, boolean mayUseOffPeak) throws IOException {
ArrayList<StoreFile> applyCompactionPolicy(ArrayList<StoreFile> candidates,
boolean mayUseOffPeak, boolean mayBeStuck) throws IOException {
if (candidates.isEmpty()) {
return candidates;
}
@ -298,11 +296,14 @@ public class RatioBasedCompactionPolicy extends CompactionPolicy {
if (start < countOfFiles) {
LOG.info("Default compaction algorithm has selected " + (countOfFiles - start)
+ " files from " + countOfFiles + " candidates");
} else if (mayBeStuck) {
// We may be stuck. Compact the latest files if we can.
int filesToLeave = candidates.size() - comConf.getMinFilesToCompact();
if (filesToLeave >= 0) {
start = filesToLeave;
}
}
if (start > 0) {
candidates.subList(0, start).clear();
}
candidates.subList(0, start).clear();
return candidates;
}

2
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/EverythingPolicy.java
View File

@ -43,7 +43,7 @@ public class EverythingPolicy extends RatioBasedCompactionPolicy {
@Override
final ArrayList<StoreFile> applyCompactionPolicy(final ArrayList<StoreFile> candidates,
final boolean mayUseOffPeak) throws IOException {
final boolean mayUseOffPeak, final boolean mayBeStuck) throws IOException {
if (candidates.size() < comConf.getMinFilesToCompact()) {
return new ArrayList<StoreFile>(0);