Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-11979 Compaction progress reporting is wrong (Esteban Gutierrez)

This commit is contained in:
Andrew Purtell 2014-12-09 12:46:35 -08:00
parent 1c99261f53
commit d4c94a409a
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
View File

@ -126,10 +126,10 @@ public abstract class Compactor {
LOG.warn("Null reader for " + file.getPath()); LOG.warn("Null reader for " + file.getPath());
continue; continue;
} }
// NOTE: getFilterEntries could cause under-sized blooms if the user // NOTE: use getEntries when compacting instead of getFilterEntries, otherwise under-sized
// switches bloom type (e.g. from ROW to ROWCOL) // blooms can cause progress to be miscalculated or if the user switches bloom
long keyCount = (r.getBloomFilterType() == store.getFamily().getBloomFilterType()) // type (e.g. from ROW to ROWCOL)
? r.getFilterEntries() : r.getEntries(); long keyCount = r.getEntries();
fd.maxKeyCount += keyCount; fd.maxKeyCount += keyCount;
// calculate the latest MVCC readpoint in any of the involved store files // calculate the latest MVCC readpoint in any of the involved store files
Map<byte[], byte[]> fileInfo = r.loadFileInfo(); Map<byte[], byte[]> fileInfo = r.loadFileInfo();