Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-18473 VC.listLabels() erroneously closes any connection.

This commit is contained in:
anoopsamjohn 2017-07-30 15:38:18 +05:30
parent 12b9a151e6
commit d776a3caae
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityClient.java
View File

@ -259,9 +259,7 @@ public class VisibilityClient {
*/ */
public static ListLabelsResponse listLabels(Connection connection, final String regex) public static ListLabelsResponse listLabels(Connection connection, final String regex)
throws Throwable { throws Throwable {
Table table = null; try (Table table = connection.getTable(LABELS_TABLE_NAME)) {
try {
table = connection.getTable(LABELS_TABLE_NAME);
Batch.Call<VisibilityLabelsService, ListLabelsResponse> callable = Batch.Call<VisibilityLabelsService, ListLabelsResponse> callable =
new Batch.Call<VisibilityLabelsService, ListLabelsResponse>() { new Batch.Call<VisibilityLabelsService, ListLabelsResponse>() {
ServerRpcController controller = new ServerRpcController(); ServerRpcController controller = new ServerRpcController();
@ -289,14 +287,6 @@ public class VisibilityClient {
return result.values().iterator().next(); // There will be exactly one region for labels return result.values().iterator().next(); // There will be exactly one region for labels
// table and so one entry in result Map. // table and so one entry in result Map.
} }
finally {
if (table != null) {
table.close();
}
if (connection != null) {
connection.close();
}
}
} }
/** /**