HBASE-25877 Add access check for compactionSwitch (#3253)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
This commit is contained in:
lujiefsi 2021-06-22 23:37:36 +08:00 committed by GitHub
parent d44292ac1a
commit d9bd29603b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 13 deletions

View File

@ -1711,22 +1711,18 @@ public class RSRpcServices implements HBaseRPCErrorHandler,
@Override
public CompactionSwitchResponse compactionSwitch(RpcController controller,
CompactionSwitchRequest request) throws ServiceException {
rpcPreCheck("compactionSwitch");
final CompactSplit compactSplitThread = regionServer.getCompactSplitThread();
try {
checkOpen();
requestCount.increment();
boolean prevState = compactSplitThread.isCompactionsEnabled();
CompactionSwitchResponse response =
CompactionSwitchResponse.newBuilder().setPrevState(prevState).build();
if (prevState == request.getEnabled()) {
// passed in requested state is same as current state. No action required
return response;
}
compactSplitThread.switchCompaction(request.getEnabled());
requestCount.increment();
boolean prevState = compactSplitThread.isCompactionsEnabled();
CompactionSwitchResponse response =
CompactionSwitchResponse.newBuilder().setPrevState(prevState).build();
if (prevState == request.getEnabled()) {
// passed in requested state is same as current state. No action required
return response;
} catch (IOException ie) {
throw new ServiceException(ie);
}
compactSplitThread.switchCompaction(request.getEnabled());
return response;
}
/**