Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-20509 putting List in HashSet directly without using addAll function to improve performance 

Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
This commit is contained in:
Tai-Ying Lee 2018-04-30 13:49:54 +00:00 committed by Jan Hentschel
parent 2bd4aa2d0b
commit da87ebb481
No known key found for this signature in database
GPG Key ID: 5CD818B19CC299A3
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hbase-server/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeAssignmentHelper.java
View File

@ -395,8 +395,7 @@ public class FavoredNodeAssignmentHelper {
rackSkipSet.add(primaryRack); rackSkipSet.add(primaryRack);
String secondaryRack = getOneRandomRack(rackSkipSet); String secondaryRack = getOneRandomRack(rackSkipSet);
List<ServerName> serverList = getServersFromRack(secondaryRack); List<ServerName> serverList = getServersFromRack(secondaryRack);
Set<ServerName> serverSet = new HashSet<>(); Set<ServerName> serverSet = new HashSet<>(serverList);
serverSet.addAll(serverList);
ServerName[] favoredNodes; ServerName[] favoredNodes;
if (serverList.size() >= 2) { if (serverList.size() >= 2) {
// Randomly pick up two servers from this secondary rack // Randomly pick up two servers from this secondary rack
@ -433,8 +432,7 @@ public class FavoredNodeAssignmentHelper {
} }
secondaryRack = getOneRandomRack(rackSkipSet); secondaryRack = getOneRandomRack(rackSkipSet);
serverList = getServersFromRack(secondaryRack); serverList = getServersFromRack(secondaryRack);
serverSet = new HashSet<>(); serverSet = new HashSet<>(serverList);
serverSet.addAll(serverList);
} }
// Place the secondary RS // Place the secondary RS