From e4e906f436894c6f7c2f8d389f43e2d3e8b6f391 Mon Sep 17 00:00:00 2001 From: stack Date: Sun, 13 Sep 2015 10:12:30 -0700 Subject: [PATCH] HBASE-14421 TestFastFail* are flakey; ADDENDUM --- .../java/org/apache/hadoop/hbase/client/TestFastFail.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java index f2eb8e0a361..da31a7df386 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java @@ -268,18 +268,20 @@ public class TestFastFail { assertEquals("The regionservers that returned true should equal to the" + " number of successful threads", numThreadsReturnedTrue, numSuccessfullThreads.get()); + assertTrue( + "There should be atleast one thread that retried instead of failing", + MyPreemptiveFastFailInterceptor.numBraveSouls.get() > 0); + /* 'should' is not worthy of an assert. Disabling because randomly this seems to randomly * not but true. St.Ack 20151012 * - * assertTrue( - "There should be atleast one thread that retried instead of failing", - MyPreemptiveFastFailInterceptor.numBraveSouls.get() > 0);*/ assertTrue( "There should be atleast one PreemptiveFastFail exception," + " otherwise, the test makes little sense." + "numPreemptiveFastFailExceptions: " + numPreemptiveFastFailExceptions.get(), numPreemptiveFastFailExceptions.get() > 0); + */ assertTrue( "Only few thread should ideally be waiting for the dead " + "regionserver to be coming back. numBlockedWorkers:"