Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-20090 Properly handle Preconditions check failure in MemStoreFlusher.run

This commit is contained in:
tedyu 2018-03-20 21:02:09 -07:00
parent acbdb86bb4
commit e7cfdac7b5
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
View File

@ -43,7 +43,6 @@ import org.apache.hadoop.hbase.DroppedSnapshotException;
import org.apache.hadoop.hbase.HConstants; import org.apache.hadoop.hbase.HConstants;
import org.apache.hadoop.hbase.client.RegionReplicaUtil; import org.apache.hadoop.hbase.client.RegionReplicaUtil;
import org.apache.hadoop.hbase.regionserver.HRegion.FlushResult; import org.apache.hadoop.hbase.regionserver.HRegion.FlushResult;
import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
import org.apache.hadoop.hbase.trace.TraceUtil; import org.apache.hadoop.hbase.trace.TraceUtil;
import org.apache.hadoop.hbase.util.Bytes; import org.apache.hadoop.hbase.util.Bytes;
import org.apache.hadoop.hbase.util.EnvironmentEdgeManager; import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
@ -254,8 +253,13 @@ class MemStoreFlusher implements FlushRequester {
bestRegionReplicaSize = getMemStoreDataSize(bestRegionReplica); bestRegionReplicaSize = getMemStoreDataSize(bestRegionReplica);
} }
Preconditions.checkState( if ((regionToFlush == null || regionToFlushSize == 0) && bestRegionReplicaSize == 0) {
(regionToFlush != null && regionToFlushSize > 0) || bestRegionReplicaSize > 0); // A concurrency issue (such as splitting region) may happen such that the online region
// seen by getCopyOfOnlineRegionsSortedByXX() method is no longer eligible to
// getBiggestMemStoreRegion(). This means that we can come out of the loop
LOG.debug("Above memory mark but there is no flushable region");
return false;
}
if (regionToFlush == null || if (regionToFlush == null ||
(bestRegionReplica != null && (bestRegionReplica != null &&