Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-19439 Mark ShortCircuitMasterConnection with InterfaceAudience Private.

This commit is contained in:
anoopsamjohn 2017-12-07 11:22:40 +05:30
parent 4833e63d17
commit e88b3c65b9
3 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterCallable.java
View File

@ -27,6 +27,7 @@ import org.apache.hadoop.hbase.ipc.HBaseRpcController;
import org.apache.hadoop.hbase.ipc.RpcControllerFactory; import org.apache.hadoop.hbase.ipc.RpcControllerFactory;
import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil; import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
import org.apache.hadoop.hbase.util.Bytes; import org.apache.hadoop.hbase.util.Bytes;
import org.apache.yetus.audience.InterfaceAudience;
/** /**
* A RetryingCallable for Master RPC operations. * A RetryingCallable for Master RPC operations.
@ -41,6 +42,7 @@ import org.apache.hadoop.hbase.util.Bytes;
* it has to deal with Coprocessor Endpoints. * it has to deal with Coprocessor Endpoints.
* @param <V> return type * @param <V> return type
*/ */
@InterfaceAudience.Private
abstract class MasterCallable<V> implements RetryingCallable<V>, Closeable { abstract class MasterCallable<V> implements RetryingCallable<V>, Closeable {
protected final ClusterConnection connection; protected final ClusterConnection connection;
protected MasterKeepAliveConnection master; protected MasterKeepAliveConnection master;

2
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterKeepAliveConnection.java
View File

@ -21,6 +21,7 @@
package org.apache.hadoop.hbase.client; package org.apache.hadoop.hbase.client;
import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos; import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos;
import org.apache.yetus.audience.InterfaceAudience;
/** /**
* A KeepAlive connection is not physically closed immediately after the close, * A KeepAlive connection is not physically closed immediately after the close,
@ -33,6 +34,7 @@ import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos;
* against the master on the MasterProtos.MasterService.BlockingInterface; but not by * against the master on the MasterProtos.MasterService.BlockingInterface; but not by
* final user code. Hence it's package protected. * final user code. Hence it's package protected.
*/ */
@InterfaceAudience.Private
interface MasterKeepAliveConnection extends MasterProtos.MasterService.BlockingInterface { interface MasterKeepAliveConnection extends MasterProtos.MasterService.BlockingInterface {
// Do this instead of implement Closeable because closeable returning IOE is PITA. // Do this instead of implement Closeable because closeable returning IOE is PITA.
void close(); void close();

2
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ShortCircuitMasterConnection.java
View File

@ -173,7 +173,7 @@ import org.apache.hadoop.hbase.shaded.protobuf.generated.ReplicationProtos.Updat
* A short-circuit connection that can bypass the RPC layer (serialization, deserialization, * A short-circuit connection that can bypass the RPC layer (serialization, deserialization,
* networking, etc..) when talking to a local master * networking, etc..) when talking to a local master
*/ */
@InterfaceAudience.Public @InterfaceAudience.Private
public class ShortCircuitMasterConnection implements MasterKeepAliveConnection { public class ShortCircuitMasterConnection implements MasterKeepAliveConnection {
private final MasterService.BlockingInterface stub; private final MasterService.BlockingInterface stub;