Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-16314 Retry on table snapshot failure during full backup (Vladimir Rodionov)

This commit is contained in:
tedyu 2017-04-21 16:15:07 -07:00
parent a3b6f4addc
commit e95cf479c7
2 changed files with 44 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupRestoreConstants.java
View File

@ -37,6 +37,16 @@ public interface BackupRestoreConstants {
public final static int BACKUP_SYSTEM_TTL_DEFAULT = HConstants.FOREVER; public final static int BACKUP_SYSTEM_TTL_DEFAULT = HConstants.FOREVER;
public final static String BACKUP_ENABLE_KEY = "hbase.backup.enable"; public final static String BACKUP_ENABLE_KEY = "hbase.backup.enable";
public final static boolean BACKUP_ENABLE_DEFAULT = false; public final static boolean BACKUP_ENABLE_DEFAULT = false;
public static final String BACKUP_MAX_ATTEMPTS_KEY = "hbase.backup.attempts.max";
public static final int DEFAULT_BACKUP_MAX_ATTEMPTS = 10;
public static final String BACKUP_ATTEMPTS_PAUSE_MS_KEY = "hbase.backup.attempts.pause.ms";
public static final int DEFAULT_BACKUP_ATTEMPTS_PAUSE_MS = 10000;
/* /*
* Drivers option list * Drivers option list
*/ */

36
hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/FullTableBackupClient.java
View File

@ -18,6 +18,11 @@
package org.apache.hadoop.hbase.backup.impl; package org.apache.hadoop.hbase.backup.impl;
import static org.apache.hadoop.hbase.backup.BackupRestoreConstants.BACKUP_ATTEMPTS_PAUSE_MS_KEY;
import static org.apache.hadoop.hbase.backup.BackupRestoreConstants.BACKUP_MAX_ATTEMPTS_KEY;
import static org.apache.hadoop.hbase.backup.BackupRestoreConstants.DEFAULT_BACKUP_ATTEMPTS_PAUSE_MS;
import static org.apache.hadoop.hbase.backup.BackupRestoreConstants.DEFAULT_BACKUP_MAX_ATTEMPTS;
import java.io.IOException; import java.io.IOException;
import java.util.HashMap; import java.util.HashMap;
import java.util.List; import java.util.List;
@ -148,8 +153,7 @@ public class FullTableBackupClient extends TableBackupClient {
"snapshot_" + Long.toString(EnvironmentEdgeManager.currentTime()) + "_" "snapshot_" + Long.toString(EnvironmentEdgeManager.currentTime()) + "_"
+ tableName.getNamespaceAsString() + "_" + tableName.getQualifierAsString(); + tableName.getNamespaceAsString() + "_" + tableName.getQualifierAsString();
admin.snapshot(snapshotName, tableName); snapshotTable(admin, tableName, snapshotName);
backupInfo.setSnapshotName(tableName, snapshotName); backupInfo.setSnapshotName(tableName, snapshotName);
} }
@ -186,4 +190,32 @@ public class FullTableBackupClient extends TableBackupClient {
} }
private void snapshotTable(Admin admin, TableName tableName, String snapshotName)
throws IOException {
int maxAttempts =
conf.getInt(BACKUP_MAX_ATTEMPTS_KEY, DEFAULT_BACKUP_MAX_ATTEMPTS);
int pause =
conf.getInt(BACKUP_ATTEMPTS_PAUSE_MS_KEY, DEFAULT_BACKUP_ATTEMPTS_PAUSE_MS);
int attempts = 0;
while (attempts++ < maxAttempts) {
try {
admin.snapshot(snapshotName, tableName);
return;
} catch (IOException ee) {
LOG.warn("Snapshot attempt " + attempts + " failed for table " + tableName
+ ", sleeping for " + pause + "ms", ee);
if (attempts < maxAttempts) {
try {
Thread.sleep(pause);
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
break;
}
}
}
}
throw new IOException("Failed to snapshot table "+ tableName);
}
} }