diff --git a/CHANGES.txt b/CHANGES.txt index e9c0478fc6f..dc4f8464175 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -196,6 +196,8 @@ Release 0.91.0 - Unreleased (Michael Weng) HBASE-4181 HConnectionManager can't find cached HRegionInterface and makes clients work very slow (Jia Liu) + HBASE-4156 ZKConfig defaults clientPort improperly (Michajlo Matijkiw) + IMPROVEMENTS HBASE-3290 Max Compaction Size (Nicolas Spiegelberg via Stack) diff --git a/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java b/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java index 24bcafef09a..d1a03a57f15 100644 --- a/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java +++ b/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKConfig.java @@ -47,8 +47,7 @@ public class ZKConfig { private static final String ZK_CFG_PROPERTY = "hbase.zookeeper.property."; private static final int ZK_CFG_PROPERTY_SIZE = ZK_CFG_PROPERTY.length(); - private static final String ZK_CLIENT_PORT_KEY = ZK_CFG_PROPERTY - + "clientPort"; + private static final String ZK_CLIENT_PORT_KEY = "clientPort"; /** * Make a Properties object holding ZooKeeper config equivalent to zoo.cfg. diff --git a/src/test/java/org/apache/hadoop/hbase/zookeeper/TestHQuorumPeer.java b/src/test/java/org/apache/hadoop/hbase/zookeeper/TestHQuorumPeer.java index bc71e5f90a0..44be6013430 100644 --- a/src/test/java/org/apache/hadoop/hbase/zookeeper/TestHQuorumPeer.java +++ b/src/test/java/org/apache/hadoop/hbase/zookeeper/TestHQuorumPeer.java @@ -132,14 +132,11 @@ public class TestHQuorumPeer { assertEquals("foo.bar", server.addr.getHostName()); } - /** - * Test Case for HBASE-2305 - */ @Test public void testShouldAssignDefaultZookeeperClientPort() { Configuration config = HBaseConfiguration.create(); config.clear(); Properties p = ZKConfig.makeZKProps(config); assertNotNull(p); - assertEquals(2181, p.get("hbase.zookeeper.property.clientPort")); + assertEquals(2181, p.get("clientPort")); } }