Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-26579 Set storage policy of recovered edits when hbase.wal.storage.type is configured (#3948) 

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
This commit is contained in:
zhengzhuobinzzb 2021-12-18 23:17:40 +08:00 committed by GitHub
parent da616c00c7
commit ea0fe2222d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitUtil.java
View File

@ -150,6 +150,7 @@ public final class WALSplitUtil {
* named for the sequenceid in the passed <code>logEntry</code>: e.g. * named for the sequenceid in the passed <code>logEntry</code>: e.g.
* /hbase/some_table/2323432434/recovered.edits/2332. This method also ensures existence of * /hbase/some_table/2323432434/recovered.edits/2332. This method also ensures existence of
* RECOVERED_EDITS_DIR under the region creating it if necessary. * RECOVERED_EDITS_DIR under the region creating it if necessary.
* And also set storage policy for RECOVERED_EDITS_DIR if WAL_STORAGE_POLICY is configured.
* @param tableName the table name * @param tableName the table name
* @param encodedRegionName the encoded region name * @param encodedRegionName the encoded region name
* @param seqId the sequence id which used to generate file name * @param seqId the sequence id which used to generate file name
@ -184,6 +185,10 @@ public final class WALSplitUtil {
if (!walFS.exists(dir) && !walFS.mkdirs(dir)) { if (!walFS.exists(dir) && !walFS.mkdirs(dir)) {
LOG.warn("mkdir failed on {}", dir); LOG.warn("mkdir failed on {}", dir);
} else {
String storagePolicy =
conf.get(HConstants.WAL_STORAGE_POLICY, HConstants.DEFAULT_WAL_STORAGE_POLICY);
CommonFSUtils.setStoragePolicy(walFS, dir, storagePolicy);
} }
// Append fileBeingSplit to prevent name conflict since we may have duplicate wal entries now. // Append fileBeingSplit to prevent name conflict since we may have duplicate wal entries now.
// Append file name ends with RECOVERED_LOG_TMPFILE_SUFFIX to ensure // Append file name ends with RECOVERED_LOG_TMPFILE_SUFFIX to ensure
@ -583,4 +588,4 @@ public final class WALSplitUtil {
Path dir = getRecoveredHFilesDir(regionDir, familyName); Path dir = getRecoveredHFilesDir(regionDir, familyName);
return CommonFSUtils.listStatus(rootFS, dir); return CommonFSUtils.listStatus(rootFS, dir);
} }
} }

12
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplit.java
View File

@ -1174,6 +1174,18 @@ public class TestWALSplit {
} }
} }
@Test
public void testRecoveredEditsStoragePolicy() throws IOException {
conf.set(HConstants.WAL_STORAGE_POLICY, "ALL_SSD");
try {
Path path = createRecoveredEditsPathForRegion();
assertEquals("ALL_SSD", fs.getStoragePolicy(path.getParent()).getName());
} finally {
conf.unset(HConstants.WAL_STORAGE_POLICY);
}
}
private Writer generateWALs(int leaveOpen) throws IOException { private Writer generateWALs(int leaveOpen) throws IOException {
return generateWALs(NUM_WRITERS, ENTRIES, leaveOpen, 0); return generateWALs(NUM_WRITERS, ENTRIES, leaveOpen, 0);
} }