Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-16172 Unify the retry logic in ScannerCallableWithReplicas and RpcRetryingCallerWithReadReplicas

This commit is contained in:
tedyu 2016-07-18 03:35:10 -07:00
parent cf0f4f72d9
commit eb43f0a5d0
3 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
View File

@ -440,7 +440,7 @@ public class HTable implements Table {
connConfiguration.getRetriesNumber(), connConfiguration.getRetriesNumber(),
operationTimeout, operationTimeout,
connConfiguration.getPrimaryCallTimeoutMicroSecond()); connConfiguration.getPrimaryCallTimeoutMicroSecond());
return callable.call(); return callable.call(operationTimeout);
} }

14
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerWithReadReplicas.java
View File

@ -27,6 +27,7 @@ import java.util.concurrent.ExecutionException;
import java.util.concurrent.ExecutorService; import java.util.concurrent.ExecutorService;
import java.util.concurrent.Future; import java.util.concurrent.Future;
import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
@ -188,7 +189,7 @@ public class RpcRetryingCallerWithReadReplicas {
* Globally, the number of retries, timeout and so on still applies, but it's per replica, * Globally, the number of retries, timeout and so on still applies, but it's per replica,
* not global. We continue until all retries are done, or all timeouts are exceeded. * not global. We continue until all retries are done, or all timeouts are exceeded.
*/ */
public synchronized Result call() public Result call(int operationTimeout)
throws DoNotRetryIOException, InterruptedIOException, RetriesExhaustedException { throws DoNotRetryIOException, InterruptedIOException, RetriesExhaustedException {
boolean isTargetReplicaSpecified = (get.getReplicaId() >= 0); boolean isTargetReplicaSpecified = (get.getReplicaId() >= 0);
@ -221,10 +222,17 @@ public class RpcRetryingCallerWithReadReplicas {
try { try {
try { try {
Future<Result> f = cs.take(); long start = EnvironmentEdgeManager.currentTime();
return f.get(); Future<Result> f = cs.poll(operationTimeout, TimeUnit.MILLISECONDS);
long duration = EnvironmentEdgeManager.currentTime() - start;
if (f == null) {
throw new RetriesExhaustedException("timed out after " + duration + " ms");
}
return f.get(operationTimeout - duration, TimeUnit.MILLISECONDS);
} catch (ExecutionException e) { } catch (ExecutionException e) {
throwEnrichedException(e, retries); throwEnrichedException(e, retries);
} catch (TimeoutException te) {
throw new RetriesExhaustedException("timed out after " + operationTimeout + " ms");
} }
} catch (CancellationException e) { } catch (CancellationException e) {
throw new InterruptedIOException(); throw new InterruptedIOException();

5
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallableWithReplicas.java
View File

@ -41,6 +41,7 @@ import org.apache.hadoop.hbase.RegionLocations;
import org.apache.hadoop.hbase.TableName; import org.apache.hadoop.hbase.TableName;
import org.apache.hadoop.hbase.classification.InterfaceAudience; import org.apache.hadoop.hbase.classification.InterfaceAudience;
import org.apache.hadoop.hbase.util.Bytes; import org.apache.hadoop.hbase.util.Bytes;
import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
import org.apache.hadoop.hbase.util.Pair; import org.apache.hadoop.hbase.util.Pair;
import com.google.common.annotations.VisibleForTesting; import com.google.common.annotations.VisibleForTesting;
@ -195,9 +196,11 @@ class ScannerCallableWithReplicas implements RetryingCallable<Result[]> {
addCallsForOtherReplicas(cs, rl, 0, rl.size() - 1); addCallsForOtherReplicas(cs, rl, 0, rl.size() - 1);
try { try {
long start = EnvironmentEdgeManager.currentTime();
Future<Pair<Result[], ScannerCallable>> f = cs.poll(timeout, TimeUnit.MILLISECONDS); Future<Pair<Result[], ScannerCallable>> f = cs.poll(timeout, TimeUnit.MILLISECONDS);
long duration = EnvironmentEdgeManager.currentTime() - start;
if (f != null) { if (f != null) {
Pair<Result[], ScannerCallable> r = f.get(timeout, TimeUnit.MILLISECONDS); Pair<Result[], ScannerCallable> r = f.get(timeout - duration, TimeUnit.MILLISECONDS);
if (r != null && r.getSecond() != null) { if (r != null && r.getSecond() != null) {
updateCurrentlyServingReplica(r.getSecond(), r.getFirst(), done, pool); updateCurrentlyServingReplica(r.getSecond(), r.getFirst(), done, pool);
} }