Apache/hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Shenshengli hbase-25450 The parameter "hbase.bucketcache.size" is misdescribed (#2821)

Browse Source 
Signed-off-by: Anoop Sam John <anoopsamjohn@apache.org>
Signed-off-by: stack <stack@apache.org>
This commit is contained in:
申胜利 2021-01-04 01:27:08 +08:00 committed by GitHub
parent 2e21da7597
commit eef076828a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
View File

@ -1400,9 +1400,7 @@ public final class HConstants {
public static final String BUCKET_CACHE_IOENGINE_KEY = "hbase.bucketcache.ioengine"; public static final String BUCKET_CACHE_IOENGINE_KEY = "hbase.bucketcache.ioengine";
/** /**
* When using bucket cache, this is a float that EITHER represents a percentage of total heap * When using bucket cache, it is the capacity in megabytes of the cache.
* memory size to give to the cache (if &lt; 1.0) OR, it is the capacity in
* megabytes of the cache.
*/ */
public static final String BUCKET_CACHE_SIZE_KEY = "hbase.bucketcache.size"; public static final String BUCKET_CACHE_SIZE_KEY = "hbase.bucketcache.size";

4
hbase-common/src/main/resources/hbase-default.xml
View File

@ -1033,9 +1033,7 @@ possible configurations would overwhelm and obscure the important.
<property> <property>
<name>hbase.bucketcache.size</name> <name>hbase.bucketcache.size</name>
<value></value> <value></value>
<description>A float that EITHER represents a percentage of total heap memory <description>It is the total capacity in megabytes of BucketCache. Default: 0.0</description>
size to give to the cache (if &lt; 1.0) OR, it is the total capacity in
megabytes of BucketCache. Default: 0.0</description>
</property> </property>
<property> <property>
<name>hbase.bucketcache.bucket.sizes</name> <name>hbase.bucketcache.bucket.sizes</name>

2
hbase-server/src/main/java/org/apache/hadoop/hbase/io/util/MemorySizeUtil.java
View File

@ -234,7 +234,7 @@ public class MemorySizeUtil {
} }
/** /**
* @param conf used to read config for bucket cache size. (< 1 is treated as % and > is treated as MiB) * @param conf used to read config for bucket cache size.
* @return the number of bytes to use for bucket cache, negative if disabled. * @return the number of bytes to use for bucket cache, negative if disabled.
*/ */
public static long getBucketCacheSize(final Configuration conf) { public static long getBucketCacheSize(final Configuration conf) {

1
src/main/asciidoc/_chapters/hbase-default.adoc
View File

@ -1242,6 +1242,7 @@ Whether or not the bucketcache is used in league with the LRU
.Description .Description
Used along with bucket cache, this is a float that EITHER represents a percentage of total heap Used along with bucket cache, this is a float that EITHER represents a percentage of total heap
memory size to give to the cache (if < 1.0) OR, it is the capacity in megabytes of the cache. memory size to give to the cache (if < 1.0) OR, it is the capacity in megabytes of the cache.
(After HBase-2.0, "hbase.bucketcache.size" cannot be between 0-1)
+ +
.Default .Default
`0` when specified as a float `0` when specified as a float