Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-1583 Start/Stop of large cluster untenable 

git-svn-id: https://svn.apache.org/repos/asf/hadoop/hbase/trunk@794905 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael Stack 2009-07-16 23:24:21 +00:00
parent 53b3084c85
commit ef30d39681
4 changed files with 31 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES.txt
View File

@ -272,6 +272,7 @@ Release 0.20.0 - Unreleased
time we cycle the hstore.getStorefilesCount() >
this.blockingStoreFilesNumber loop
HBASE-1058 Disable 1058 on catalog tables
HBASE-1583 Start/Stop of large cluster untenable
IMPROVEMENTS
HBASE-1089 Add count of regions on filesystem to master UI; add percentage

11
src/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
View File

@ -26,17 +26,16 @@ import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.locks.ReentrantLock;
import org.apache.hadoop.util.StringUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.hbase.HBaseConfiguration;
import org.apache.hadoop.hbase.HConstants;
import org.apache.hadoop.hbase.HRegionInfo;
import org.apache.hadoop.hbase.RemoteExceptionHandler;
import org.apache.hadoop.hbase.client.HTable;
import org.apache.hadoop.hbase.client.Put;
import org.apache.hadoop.hbase.HBaseConfiguration;
import org.apache.hadoop.hbase.RemoteExceptionHandler;
import org.apache.hadoop.hbase.HRegionInfo;
import org.apache.hadoop.hbase.HConstants;
import org.apache.hadoop.hbase.util.Bytes;
import org.apache.hadoop.hbase.util.Writables;
import org.apache.hadoop.util.StringUtils;
/**
* Compact region on request and then run split if appropriate

21
src/java/org/apache/hadoop/hbase/regionserver/HRegion.java
View File

@ -343,6 +343,20 @@ public class HRegion implements HConstants, HeapSize { // , Writable{
" available; sequence id is " + this.minSequenceId);
}
/**
* @return True if this region has references.
*/
boolean hasReferences() {
for (Map.Entry<byte [], Store> e: this.stores.entrySet()) {
for (Map.Entry<Long, StoreFile> ee:
e.getValue().getStorefiles().entrySet()) {
// Found a reference, return.
if (ee.getValue().isReference()) return true;
}
}
return false;
}
/*
* Write out an info file under the region directory. Useful recovering
* mangled regions.
@ -747,6 +761,10 @@ public class HRegion implements HConstants, HeapSize { // , Writable{
*/
byte [] compactStores(final boolean majorCompaction)
throws IOException {
if (this.closing.get() || this.closed.get()) {
LOG.debug("Skipping compaction on " + this + " because closing/closed");
return null;
}
splitsAndClosesLock.readLock().lock();
try {
byte [] splitRow = null;
@ -1487,12 +1505,13 @@ public class HRegion implements HConstants, HeapSize { // , Writable{
private boolean isFlushSize(final long size) {
return size > this.memstoreFlushSize;
}
// Do any reconstruction needed from the log
protected void doReconstructionLog(Path oldLogFile, long minSeqId, long maxSeqId,
Progressable reporter)
throws UnsupportedEncodingException, IOException {
// Nothing to do (Replaying is done in HStores)
// Used by subclasses; e.g. THBase.
}
protected Store instantiateHStore(Path baseDir,

8
src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
View File

@ -1553,9 +1553,11 @@ public class HRegionServer implements HConstants, HRegionInterface,
if (region == null) {
try {
region = instantiateRegion(regionInfo);
// Startup a compaction early if one is needed.
this.compactSplitThread.
compactionRequested(region, "Region open check");
// Startup a compaction early if one is needed, if region has references.
if (region.hasReferences()) {
this.compactSplitThread.compactionRequested(region,
"Region has references on open");
}
} catch (Throwable e) {
Throwable t = cleanup(e,
"Error opening " + regionInfo.getRegionNameAsString());